6.0.2 #3
Merged
6.0.2 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bajankristof
commented
Jun 18, 2024
bajankristof
commented
- Fixes a crash where extremely long media files would cause the transcoder to fail with SystemStackError: stack level too deep
bajankristof
force-pushed
the
bugfix/timeout-system-stack-error
branch
from
dcc77c4 to
f610951
Compare
kiskoza
reviewed
Jun 19, 2024
| @@ -16,6 +16,7 @@ def pause | |||
|
|
|||
| def resume | |||
| @paused = false | |||
| tick | |||
There was a problem hiding this comment.
this one seems to cause a race condition, I would change the order of the lines
the tick call is setting the @last_tick to the current date to not cause a timeout after a long pause, but the loop int the other thread can do its check between setting @paused to false and setting the @last_tick to the current time. this could end up breaking the sleep loop while we meant to keep it running (hence setting the time to be Time.now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.