Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.0.0 #1

Merged
merged 1 commit into from
Jun 5, 2024
Merged

6.0.0 #1

merged 1 commit into from
Jun 5, 2024

Conversation

bajankristof
Copy link
Collaborator

Breaking Changes:

  • Changed FFMPEG::IO to use UTF-8 encoding instead of ISO-8859-1 by default
  • Changed FFMPEG::Transcoder#run to raise FFMPEG::Error if FFMPEG exits with non-zero exit code even if validate was set to false on the transcoder
  • Removed the errors attribute of FFMPEG::Transcoder

Improvements:

  • Changed FFMPEG::IO to handle carriage returns by FFMPEG – progress reports will be more frequent and more reliable
  • Changed FFMPEG::Transcoder to report progress only on whole percentages by default (e.g.: 0.01, 0.2 etc.)
  • Added new progress_digits kwarg to FFMPEG::Transcoder to allow more frequent progress updates

Copy link
Collaborator

@ZoltanDalmadi ZoltanDalmadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ZoltanDalmadi ZoltanDalmadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bajankristof bajankristof merged commit 599d7a7 into main Jun 5, 2024
13 checks passed
@bajankristof bajankristof deleted the 2024-06-05 branch June 5, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants