Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tonsil Knowledge #692

Closed
wants to merge 5 commits into from
Closed

Tonsil Knowledge #692

wants to merge 5 commits into from

Conversation

luke-inglis
Copy link
Contributor

If your PR is related to a contribution to the taxonomy, please, fill
out the following questionnaire. If not, replace this whole text and the
following questionnaire with whatever information is applicable to your PR.

Describe the contribution to the taxonomy

Knowledge of tonsils

Input given at the prompt

What is the location of the Tubal tonsils

Response from the original model

Tubal tonsils, also known as ampullary tonsils or infundibulopelvic tonsils, are small clusters of lymphoid tissue found at the junction between the uterine tube (also called the fallopian tube) and the ovary. They play a role in the immune system's defense against potential pathogens that may enter the reproductive tract through the vagina. The exact positioning of tubal tonsils can vary slightly among individuals, but they are generally located near the fimbriated ends of the uterine tubes, which are responsible for capturing and transporting ova to the uterus during each menstrual cycle.

Response from the fine-tuned model

I did not try the CLI

Contribution checklist

@luke-inglis luke-inglis requested a review from a team as a code owner April 14, 2024 15:15
@github-actions github-actions bot added triage-needed (Auto labeled) skill is ready to be triaged knowledge (Auto labeled) labels Apr 14, 2024
@luke-inglis luke-inglis changed the title Create qna.yaml Tonsil Knowledge Apr 14, 2024
@luke-inglis
Copy link
Contributor Author

@instruct-lab-bot enable

Copy link
Contributor

@juliadenham juliadenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix signoff and whitespace errors, otherwise it looks good to me!

@bmr-cymru
Copy link

Shouldn't the LICENSE file in the knowledge repo be the CC-BY-SA-4.0 instread of the Apache license, since the content comes from the Wikipedia tonsils article?

Also the README.md now specifies an attribution.txt file to document attribution for knowledge sources.

Signed-off-by: Luke Inglis <Luke.Inglis@ibm.com>
@luke-inglis luke-inglis reopened this Apr 15, 2024
Signed-off-by: Luke Inglis <Luke.Inglis@ibm.com>
Signed-off-by: Luke Inglis <Luke.Inglis@ibm.com>
Copy link
Contributor

@juliadenham juliadenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliadenham juliadenham added community-build-ready Triage Team has signed off for synthetic data generation and removed triage-needed (Auto labeled) skill is ready to be triaged labels Apr 15, 2024
@luke-inglis
Copy link
Contributor Author

@instruct-lab-bot enable

Copy link

Beep, boop 🤖 Hi, I'm @instruct-lab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instruct-lab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instruct-lab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instruct-lab-bot generate-local -- Generate a sample of synthetic data using a local model.

@luke-inglis
Copy link
Contributor Author

@instruct-lab-bot precheck

@luke-inglis
Copy link
Contributor Author

@instruct-lab-bot generate

@oindrillac
Copy link
Contributor

synthetic generated data for your review @luke-inglis (triage tool mockup, until support is enabled)

 "messages":[{"content":"What are the four types of tonsils found in humans and where are they located?","role":"user"},{"content":"The four types of tonsils found in humans are the pharyngeal tonsil (also known as the adenoid), tubal tonsils, palatine tonsils, and lingual tonsils. The adenoid is located in the roof of the pharynx, the tubal tonsils are found in the roof of the pharynx as well, the palatine tonsils are situated on either side of the back of the human throat, and the lingual tonsils are located at the back of the tongue, behind the terminal sulcus.","role":"assistant"}]"
"messages":[{"content":"What is the structure of the palatine tonsils, including the type of epithelium, presence of a capsule, and the nature of tonsillar crypts?","role":"user"},{"content":"The palatine tonsils are composed of non-keratinized stratified squamous epithelium and are incompletely encapsulated. They have long, branched tonsillar crypts, which are invaginations of the epithelium that form deep recesses in the tissue.","role":"assistant"}]"
"messages":[{"content":"How do the tonsils contribute to the immune system's defense against foreign pathogens?","role":"user"},{"content":"The tonsils are immunocompetent organs that serve as the immune system's first line of defense against ingested or inhaled foreign pathogens. They contain specialized antigen capture cells called microfold cells (M cells) that allow for the uptake of antigens produced by pathogens. These M cells then alert the B cells and T cells in the tonsil that a pathogen is present, stimulating an immune response. B cells are activated and proliferate in areas called germinal centers in the tonsil, where B memory cells are created and secretory antibody (IgA) is produced.","role":"assistant"}]"
"messages":[{"content":"What are some common treatments for tonsillitis and when might surgical removal of the tonsils be advised?","role":"user"},{"content":"The most common treatments for tonsillitis are anti-inflammatory drugs such as ibuprofen or, if bacterial in origin, antibiotics such as amoxicillin and azithromycin. Surgical removal of the tonsils (tonsillectomy) may be advised if the tonsils obstruct the airway or interfere with swallowing, or in patients with severe or recurrent tonsillitis. However, different mechanisms of pathogenesis for these two subtypes of tonsillar hypertrophy may have different responses to identical therapeutic efforts.","role":"assistant"}]"
"messages":[{"content":"What is a tonsillolith and what is it composed of?","role":"user"},{"content":"A tonsillolith (also known as a \"tonsil stone\") is material that accumulates on the palatine tonsil. It can reach the size of a peppercorn and is white or cream in color. The main substance of a tonsillolith is mostly calcium, but it has a strong unpleasant odor due to hydrogen sulfide, methyl mercaptan, and other chemicals.","role":"assistant"}]"

oindrillac added a commit that referenced this pull request Apr 15, 2024
Copy link
Member

@aakankshaduggal aakankshaduggal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luke-inglis - These two changes are required for the backend.

knowledge/textbook/tonsil/qna.yaml Outdated Show resolved Hide resolved
knowledge/textbook/tonsil/qna.yaml Show resolved Hide resolved
Signed-off-by: Aakanksha Duggal <aduggal@redhat.com>
Signed-off-by: Aakanksha Duggal <aduggal@redhat.com>
@github-actions github-actions bot added the triage-needed (Auto labeled) skill is ready to be triaged label Apr 15, 2024
oindrillac added a commit that referenced this pull request Apr 16, 2024
@mingxzhao
Copy link
Member

@instruct-lab-bot enable

Copy link

Beep, boop 🤖 Sorry, An error has occurred : User mingxzhao is not allowed to enable the instruct bot. Only [taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers] teams are allowed to enable the bot.

@instructlab instructlab deleted a comment from instruct-lab-bot bot Apr 16, 2024
@instructlab instructlab deleted a comment from instruct-lab-bot bot Apr 16, 2024
@instructlab instructlab deleted a comment from instruct-lab-bot bot Apr 16, 2024
@instructlab instructlab deleted a comment from instruct-lab-bot bot Apr 16, 2024
@bjhargrave
Copy link
Contributor

@instruct-lab-bot enable

Copy link

Beep, boop 🤖 Sorry, An error has occurred : User bjhargrave is not allowed to enable the instruct bot. Only [taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers] teams are allowed to enable the bot.

@juliadenham
Copy link
Contributor

@instruct-lab-bot enable

Copy link

Beep, boop 🤖 Sorry, An error has occurred : User juliadenham is not allowed to enable the instruct bot. Only [taxonomy-triagers taxonomy-approvers taxonomy-maintainers labrador-org-maintainers] teams are allowed to enable the bot.

@aakankshaduggal
Copy link
Member

@luke-inglis can we also add attribution.txt file to this PR.

oindrillac added a commit that referenced this pull request Apr 16, 2024
@mingxzhao
Copy link
Member

@instruct-lab-bot enable

Copy link

Beep, boop .. Hi, I'm @instruct-lab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉

I support the following commands:

  • @instruct-lab-bot precheck -- Check existing model behavior using the questions in this proposed change.
  • @instruct-lab-bot generate -- Generate a sample of synthetic data using the synthetic data generation backend infrastructure.
  • @instruct-lab-bot generate-local -- Generate a sample of synthetic data using a local model.

Note

Results or Errors of these commands will be posted as a pull request check in the Checks section below.

@mingxzhao
Copy link
Member

@instruct-lab-bot precheck

Copy link

Beep, boop 🤖, Generating test data for your PR with the job type: precheck. Your Job ID is 155. The results will be presented below in the pull request status box. This may take several minutes...

@mingxzhao
Copy link
Member

@instruct-lab-bot generate

Copy link

Beep, boop 🤖, Generating test data for your PR with the job type: sdg-svc. Your Job ID is 156. The results will be presented below in the pull request status box. This may take several minutes...

Copy link

Results for job ID: 155 using the model merlinite-7b!

Results can be found here.

@jjasghar jjasghar closed this Apr 19, 2024
@n1hility
Copy link
Member

Thank you for your contribution to InstructLab! Unfortunately, once a Github repo is made public, all open PRs are automatically closed since they link against a private repo. We have detected that your PR might have been one of the ones affected by this change. If you are still interested in contributing your improvement, please fill out the following short form by no later than May 3rd, and we will get back to you with the additional steps necessary once we have had time to assess the PRs of those still interested:

https://forms.gle/V7SrPPMZDo6iGDYu8

@alinaryan
Copy link
Member

alinaryan commented Jun 5, 2024

Thank you for your submission. Here are your results:
Your PR improved the granite-7b-lab model's performance by 0.03703703703703698 points.
The model's new score is: 0.7407407407407407
The old score was: 0.7037037037037037
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||| 74.07407407407408%

@alinaryan
Copy link
Member

alinaryan commented Jun 6, 2024

Thank you for your submission. Here are your results:
Your PR decreased the merlinite-7b-lab model's performance by 0.03703703703703709 points.
The model's new score is: 0.8148148148148148
The old score was: 0.8518518518518519
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||| 81.48148148148148%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-build-ready Triage Team has signed off for synthetic data generation knowledge (Auto labeled) triage-needed (Auto labeled) skill is ready to be triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants