Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add markdown linter #218

Merged
merged 2 commits into from
May 2, 2024
Merged

Conversation

nathan-weinberg
Copy link
Member

can run locally with make md-lint

@nathan-weinberg nathan-weinberg requested a review from a team as a code owner April 26, 2024 18:06
@nathan-weinberg
Copy link
Member Author

lot of Markdown Lint errors here - I'll go through them over time but too many to do in one fell swoop myself immediately

@ckadner
Copy link
Contributor

ckadner commented Apr 26, 2024

lot of Markdown Lint errors here - I'll go through them over time but too many to do in one fell swoop myself immediately

Looks like a lot of trailing white spaces. Should be possible to use basic tools, editors and even plain git to do those fixes. I'm willing to help, but don't want to duplicate any work you already did?

@ckadner ckadner self-requested a review April 26, 2024 18:49
@nathan-weinberg
Copy link
Member Author

Haven't start anything @ckadner so if you want to push commits onto this PR be my guest! Appreciate it!

@nathan-weinberg nathan-weinberg added the documentation Improvements or additions to documentation label Apr 26, 2024
@nathan-weinberg nathan-weinberg requested a review from bjhargrave May 2, 2024 14:05
@bjhargrave bjhargrave self-assigned this May 2, 2024
nathan-weinberg and others added 2 commits May 2, 2024 13:36
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
@bjhargrave
Copy link
Contributor

@nathan-weinberg I updated the workflow and fixed all the linting errors.

@nathan-weinberg nathan-weinberg merged commit a9bd0f6 into instructlab:main May 2, 2024
3 checks passed
@nathan-weinberg nathan-weinberg deleted the md-lint branch May 2, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants