Skip to content

Commit

Permalink
fix(model): move github from model to model version (#51)
Browse files Browse the repository at this point in the history
Because

- Model version have GitHub information including repository, branch, tag and commit hash

This commit

- Move GitHub from Model message to ModelVersion message
  • Loading branch information
Phelan164 authored Mar 30, 2022
1 parent 7ddc142 commit 03170d7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions instill/model/v1alpha/model.proto
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ message ModelVersion {
google.protobuf.Timestamp updated_at = 5;
// Model version status
Status status = 6;
// Model GitHub source (has value when model created by CreateModelByGitHub and is empty when created by CreateModelBinaryFileUpload)
GitHub github = 7 [ (google.api.field_behavior) = OUTPUT_ONLY ];
}

// Model represents the content of a model
Expand All @@ -128,8 +130,6 @@ message Model {
Task task = 4;
// Model versions
repeated ModelVersion model_versions = 5;
// Model GitHub source (has value when model created by CreateModelByGitHub and is empty when created by CreateModelBinaryFileUpload)
GitHub github = 6 [ (google.api.field_behavior) = OUTPUT_ONLY ];
}

// CreateModelBinaryFileUploadRequest represents a request to create a model
Expand Down

0 comments on commit 03170d7

Please sign in to comment.