Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker-compose): add INSTILL_CORE_HOST back for Console to connect to the backend properly #441

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

donch1989
Copy link
Member

Because

  • We cannot use the Docker internal address for the Console to connect to the backend.

This commit

  • Adds INSTILL_CORE_HOST back.

heiruwu
heiruwu previously approved these changes Mar 11, 2024
Copy link
Member

@heiruwu heiruwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we indeed need this back

@donch1989 donch1989 force-pushed the huitang/fix-console-env branch 2 times, most recently from 8876dc7 to 230f810 Compare March 11, 2024 12:54
@donch1989 donch1989 force-pushed the huitang/fix-console-env branch 3 times, most recently from 85c52d0 to 6264c37 Compare March 11, 2024 17:06
@donch1989 donch1989 merged commit 601f963 into main Mar 12, 2024
41 of 43 checks passed
@donch1989 donch1989 deleted the huitang/fix-console-env branch March 12, 2024 08:35
donch1989 pushed a commit that referenced this pull request Mar 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.26.0-beta](v0.25.0-beta...v0.26.0-beta)
(2024-03-12)


### Features

* **model:** support Llava 13b
([#442](#442))
([39bbf8c](39bbf8c))


### Bug Fixes

* **docker-compose:** add `INSTILL_CORE_HOST` back for Console to
connect to the backend properly
([#441](#441))
([601f963](601f963))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
donch1989 pushed a commit that referenced this pull request Mar 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.26.0-beta](v0.25.0-beta...v0.26.0-beta)
(2024-03-13)


### Features

* **model:** support Llava 13b
([#442](#442))
([39bbf8c](39bbf8c))


### Bug Fixes

* **docker-compose:** add `INSTILL_CORE_HOST` back for Console to
connect to the backend properly
([#441](#441))
([601f963](601f963))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
donch1989 pushed a commit that referenced this pull request Mar 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.26.0-beta](v0.25.0-beta...v0.26.0-beta)
(2024-03-13)


### Features

* **model:** support Llava 13b
([#442](#442))
([39bbf8c](39bbf8c))


### Bug Fixes

* **docker-compose:** add `INSTILL_CORE_HOST` back for Console to
connect to the backend properly
([#441](#441))
([601f963](601f963))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: 👋 Done
Development

Successfully merging this pull request may close these issues.

3 participants