Skip to content

Commit

Permalink
fix(docker-compose): add INSTILL_CORE_HOST back for Console to conn…
Browse files Browse the repository at this point in the history
…ect to the backend properly (#441)

Because

- We cannot use the Docker internal address for the Console to connect
to the backend.

This commit

- Adds `INSTILL_CORE_HOST` back.
  • Loading branch information
donch1989 authored Mar 12, 2024
1 parent 39bbf8c commit 601f963
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
4 changes: 4 additions & 0 deletions .env
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ INITMODEL_ENABLED=false
# configuration directory path
CONFIG_DIR_PATH=./configs

# Instill Core instance host
# Please set the IP address of your host machine.
INSTILL_CORE_HOST=localhost

# container build
DOCKER_BUILDKIT=1
COMPOSE_DOCKER_CLI_BUILD=1
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/integration-test-console.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:

- name: Launch Instill Core (latest)
run: |
make latest BUILD=true EDITION=local-ce:test ITMODE_ENABLED=true
make latest BUILD=true EDITION=local-ce:test ITMODE_ENABLED=true INSTILL_CORE_HOST=api-gateway
- name: Run console integration test (latest)
run: |
Expand Down Expand Up @@ -122,7 +122,7 @@ jobs:

- name: Launch Instill Core (release)
run: |
make all BUILD=true EDITION=local-ce:test ITMODE_ENABLED=true
make all BUILD=true EDITION=local-ce:test ITMODE_ENABLED=true INSTILL_CORE_HOST=api-gateway
- name: Run console integration test (release)
run: |
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ services:
NEXT_PUBLIC_USAGE_COLLECTION_ENABLED: ${USAGE_ENABLED}
NEXT_PUBLIC_CONSOLE_EDITION: ${EDITION}
NEXT_PUBLIC_CONSOLE_BASE_URL: http://${CONSOLE_HOST}:${CONSOLE_PORT}
NEXT_PUBLIC_API_GATEWAY_URL: http://${API_GATEWAY_HOST}:${API_GATEWAY_PORT}
NEXT_PUBLIC_API_GATEWAY_URL: http://${INSTILL_CORE_HOST}:${API_GATEWAY_PORT}
NEXT_SERVER_API_GATEWAY_URL: http://${API_GATEWAY_HOST}:${API_GATEWAY_PORT}
NEXT_PUBLIC_INSTILL_AI_USER_COOKIE_NAME: instill-ai-user
NEXT_PUBLIC_SELF_SIGNED_CERTIFICATION: "false"
Expand Down

0 comments on commit 601f963

Please sign in to comment.