fix(api-gateway): add minio port in _helpers.tpl #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yougigun
requested review from
donch1989,
jvallesm,
heiruwu and
Sarthak-instill
as code owners
jvallesm
approved these changes
Oct 31, 2024
donch1989
pushed a commit
that referenced
this pull request
Nov 5, 2024
🤖 I have created a release *beep* *boop* --- ## [0.45.0-beta](v0.44.1-beta...v0.45.0-beta) (2024-11-05) ### Features * **integration:** inject Google Drive OAuth details to pipeline and console ([#1143](#1143)) ([7ccf5ae](7ccf5ae)) ### Bug Fixes * **api-gateway:** add minio port in _helpers.tpl ([#1147](#1147)) ([04e8205](04e8205)) * **component:** add dummy OAuth information for pipeline-backend tests ([#1145](#1145)) ([30bce6f](30bce6f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
there is a lack on helpers.tpl
This commit
adds a new Helm template helper
core.minio.portto define MinIO's default port (9000)