feat(catalog): feat add warning when cloning to full namespace #1466
Conversation
thewbuk
requested review from
EiffelFly,
pinglin and
xiaofei-du
as code owners
📦 Next.js Bundle Analysis for instillai-consoleThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
77.67 KB (1 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
📦 Next.js Bundle Analysis for instillai-consoleThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
77.67 KB (1 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
packages/toolkit/src/view/catalog/components/CloneCatalogDialog.tsx
Outdated
Show resolved
Hide resolved
📦 Next.js Bundle Analysis for instillai-consoleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
1 similar comment
📦 Next.js Bundle Analysis for instillai-consoleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
| onClose, | ||
| }: CatalogLimitNotificationProps) => { | ||
| return ( | ||
| <Dialog.Root open={isOpen} onOpenChange={onClose}> |
There was a problem hiding this comment.
@thewbuk This naming is not straight forward, since onOpenChange will get triggered when dialog is opened.
You can directly name it as setIsOpen or onOpenChange
Because