fix(pipeline/models): fix add redirections #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Next.js Bundle Analysis for instillai-consoleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
EiffelFly
reviewed
Sep 10, 2024
| } | ||
| } catch (error) { | ||
| console.error(error); | ||
| return null; |
There was a problem hiding this comment.
Suggested change
| return null; | |
| return Promise.reject(null); |
packages/toolkit/src/view/pipeline/view-pipeline/PipelineContentViewer.tsx
Outdated
Show resolved
Hide resolved
📦 Next.js Bundle Analysis for instillai-consoleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
1 similar comment
📦 Next.js Bundle Analysis for instillai-consoleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
📦 Next.js Bundle Analysis for instillai-consoleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
📦 Next.js Bundle Analysis for instillai-consoleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
1 similar comment
📦 Next.js Bundle Analysis for instillai-consoleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
📦 Next.js Bundle Analysis for instillai-consoleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
1 similar comment
📦 Next.js Bundle Analysis for instillai-consoleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Merged
EiffelFly
pushed a commit
that referenced
this pull request
Sep 18, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>0.57.0-beta</summary> ## [0.57.0-beta](v0.56.0-beta...v0.57.0-beta) (2024-09-18) ### Features * change "connector" to "component" ([#1476](#1476)) ([bb2129f](bb2129f)) ### Bug Fixes * **editor:** fix recipe didn't allow asana component ([#1478](#1478)) ([aabf360](aabf360)) * **pipeline/models:** fix add redirections ([#1446](#1446)) ([77ef8fa](77ef8fa)) </details> <details><summary>@instill-ai/design-system: 0.79.0</summary> ## [0.79.0](https://github.com/instill-ai/console/compare/@instill-ai/design-system-v0.78.1...@instill-ai/design-system-v0.79.0) (2024-09-18) ### Features * **catalog:** feat support new file types ([#1467](#1467)) ([a55c7c0](a55c7c0)) * change "connector" to "component" ([#1476](#1476)) ([bb2129f](bb2129f)) </details> <details><summary>@instill-ai/toolkit: 0.103.0</summary> ## [0.103.0](https://github.com/instill-ai/console/compare/@instill-ai/toolkit-v0.102.0...@instill-ai/toolkit-v0.103.0) (2024-09-18) ### Features * **catalog:** feat support new file types ([#1467](#1467)) ([a55c7c0](a55c7c0)) * change "connector" to "component" ([#1476](#1476)) ([bb2129f](bb2129f)) * **editor:** close all imcomplete status of components when pipeline is completed ([#1473](#1473)) ([d595169](d595169)) * **editor:** make left sidebar width adjustable ([#1472](#1472)) ([c3d64f1](c3d64f1)) * **editor:** replace null with empty string when add the component ([#1469](#1469)) ([910fee3](910fee3)) * **editor:** scroll to target component line when click the node ([#1470](#1470)) ([f3ddab9](f3ddab9)) * **editor:** update node border radius and id style ([#1471](#1471)) ([4f67e6b](4f67e6b)) * import smart hint that user can directly input space to trigger hint window ([#1463](#1463)) ([aab53ba](aab53ba)) * use CMD and ctrl instead of ⌘ to hint shortcut ([#1475](#1475)) ([b92b64f](b92b64f)) ### Bug Fixes * **editor:** fix recipe didn't allow asana component ([#1478](#1478)) ([aabf360](aabf360)) * **editor:** fix the wrong indent when adding the component placeholder ([#1468](#1468)) ([8a55a7c](8a55a7c)) * **editor:** stop editor from displaying undefined hover hint ([#1474](#1474)) ([7b069d7](7b069d7)) * fix model playground polling ([#1465](#1465)) ([55d9479](55d9479)) * **pipeline/models:** fix add redirections ([#1446](#1446)) ([77ef8fa](77ef8fa)) * redirect user to 404 if they are on editor and pipeline is not exist ([#1480](#1480)) ([8a55d73](8a55d73)) ### Miscellaneous * loading placeholders for model and pipeline pages ([#1477](#1477)) ([14e5dc9](14e5dc9)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
https://instill.tech/ownerID/pipeline/pipelineID/settings tab should be redirected to playground if not owner of pipeline
https://instill.tech/ownerID/models/modelId/settings tab should be redirected to playground if not owner of model
https://instill.tech/ownerID/models/modelIDshould redirect to playground (if exists)
https://instill.tech/ownerID/models/modelIDshould redirect to 404 (if not exists)
https://instill.tech/ownerID/models/modelID/{tab} (if non existent model) should redirect to 404.
https://instill.tech/ownerID/pipeline/pipelineID should redirect to playground (if exists)
https://instill.tech/ownerID/pipeline/pipelineID should redirect to 404 (if not exists)
https://instill.tech/ownerID/pipeline/pipelineID/{tab} (if non existent pipeline) should redirect to 404