feat: added @opentelemetry/resource-detector-instana to cart service #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
changed the title
kirrg001
force-pushed
the
feat/resource-detection
branch
from
434d867 to
c78ca99
Compare
kirrg001
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the newly added Instana Otel resource detector to the cart codebase.
The resource detection processor can be used to detect resource information from the host.
In Opentelemetry there is the concept of a resource, see [Resource SDK](https://opentelemetry.io/docs/reference/specification/resource/sdk/). There are process resources, environment resources and custom resources. All will be merged into one resource object, which is attached to every trace object.
The goal for Instana is to use this component as a detector for our Instana agent and attach the real PID and the agent uuid to the custom resource. This will correlate the Otel service spans with the Otel process.