Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Currency Bot] Bumped superagent from 9.0.2 to 10.0.0 #1260

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

instanacd
Copy link
Contributor

@instanacd instanacd commented Aug 5, 2024

Tada!

INSTA-12427

  • check which breaking changes
  • Check if node v14 still working
  • Wait for the JIRA ticket and link it to it
  • merge it with a proper commit msg as single commit with ticket reference

@instanacd instanacd requested a review from a team as a code owner August 5, 2024 17:13
@abhilash-sivan
Copy link
Contributor

They have added support for brotli compression format and did some dependency updates alongside code refactoring. The existing functionalities haven't changed. changes are available here

@kirrg001
Copy link
Contributor

kirrg001 commented Aug 6, 2024

They have added support for brotli compression format and did some dependency updates alongside code refactoring. The existing functionalities haven't changed. changes are available here

Yeah, the v10 major release doesn't make any sense to me and its nowhere explained.
There is IMO no need to run multiple major versions of superagent 👍

@kirrg001
Copy link
Contributor

kirrg001 commented Aug 6, 2024

We probably need to revalidate this comment.

@kirrg001
Copy link
Contributor

kirrg001 commented Aug 6, 2024

Commit msg:

feat: added support for superagent v10

@abhilash-sivan
Copy link
Contributor

We probably need to revalidate this comment.

seems like the test completed successfully

@yigaldviri
Copy link

Hi there, sorry to interrupt but I think that superagent 10.0 isn't compatible with Node 14 (and I see you have a check here that it does).
Im the author of this pr that triggered the whole version changing and we noticed after publishing that one of the dependencies of an added dependency requires Node 16. There's a PR on that that waited to be merged

@abhilash-sivan abhilash-sivan merged commit b947d87 into main Aug 7, 2024
@abhilash-sivan abhilash-sivan deleted the currency-bot-major-superagent branch August 7, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants