Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Error Handling in Data Processing: Raise the error and not hide it with the print #39

Merged
merged 6 commits into from
Feb 1, 2024

Conversation

OmaymaMahjoub
Copy link
Collaborator

What?

This update addresses the issue of the current generic exception handling that suppresses valuable debugging information and potentially allows the code to continue execution after critical errors.

Why?

The existing approach of catching all exceptions and replacing them with custom print statement makes debugging challenging by hiding traces. Additionally, by not re-raising exceptions, the code may continue to execute despite encountering significant issues.

Extra

Close #35

@OmaymaMahjoub OmaymaMahjoub added the enhancement New feature or request label Dec 1, 2023
@OmaymaMahjoub OmaymaMahjoub self-assigned this Dec 1, 2023
Copy link
Collaborator

@RuanJohn RuanJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@OmaymaMahjoub OmaymaMahjoub merged commit 9104a73 into main Feb 1, 2024
3 checks passed
@RuanJohn RuanJohn deleted the feat/error_raise branch February 28, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors are caught and not re-raised
2 participants