Add dtype choice in step type/functions #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sash-a
requested changes
Nov 11, 2024
There was a problem hiding this comment.
Thanks for this @thomashirtz
Can you please add the dtype arg to the docstring and also sign the CLA 😄
sash-a
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Thanks @thomashirtz. Can you please sign the contributor license agreement, click the link in the first comment 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #256
I just feel that it is a little weird that this dtype argument is both responsible for both reward and discount in "restart". But otherwise it means that there are no way to choose reward's dtype at restart time.