fix: default value for obs in extras #228

clement-bonnet · 2024-03-08T21:33:47Z

give a default behavior for next_obs_in_extras that is backward compatible for AutoResetWrapper and VmapAutoResetWrapper, following fix: autoreset wrappers #223
handle non-numeric data in loggers (was crashing for next_obs of type Observation for instance)
also made the add_obs_to_extras function take a timestep instead of (state, timestep)

sash-a

Approving, so long, but please make an is_logable method.

Thanks for spotting this bug, didn't do any training runs when I made the edits to the wrapper 😄

jumanji/training/loggers.py

jumanji/wrappers.py

sash-a

clement-bonnet added 2 commits March 8, 2024 22:31

feat: deafult behavior wrappers

3e12f94

fix: loggers handle non numeric data, e.g. next obs in extra

be9ca16

clement-bonnet added the bug Something isn't working label Mar 8, 2024

clement-bonnet requested review from djbyrne and sash-a March 8, 2024 21:33

clement-bonnet self-assigned this Mar 8, 2024

clement-bonnet added 2 commits March 9, 2024 00:01

fix: linter

af939c8

fix: tests

d51621d

sash-a previously approved these changes Mar 11, 2024

View reviewed changes

jumanji/training/loggers.py Outdated Show resolved Hide resolved

jumanji/wrappers.py Show resolved Hide resolved

feat: add is_loggable

389440f

clement-bonnet dismissed sash-a’s stale review via 389440f March 11, 2024 10:06

sash-a approved these changes Mar 11, 2024

View reviewed changes

clement-bonnet enabled auto-merge (squash) March 11, 2024 10:29

clement-bonnet merged commit 8b10543 into main Mar 11, 2024
5 checks passed

clement-bonnet deleted the fix-obs-in-extras-default branch March 11, 2024 10:48

Provide feedback