Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix tests in pipeline #225

Merged
merged 3 commits into from
Mar 5, 2024
Merged

ci: fix tests in pipeline #225

merged 3 commits into from
Mar 5, 2024

Conversation

clement-bonnet
Copy link
Collaborator

@clement-bonnet clement-bonnet commented Mar 4, 2024 •
edited
Loading

  • jax.random.KeyArray -> jax.random.PRNGKey
  • use jnp.isclose instead of == for assertions with float32
  • convert MMST's frac variable to int32 because numpy uses float64 by default and Jax does not.

@clement-bonnet clement-bonnet requested review from djbyrne and sash-a March 4, 2024 13:25
@clement-bonnet clement-bonnet self-assigned this Mar 4, 2024
@clement-bonnet clement-bonnet added bug Something isn't working ci labels Mar 4, 2024
@clement-bonnet clement-bonnet mentioned this pull request Mar 4, 2024
Merged
sash-a
sash-a approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@sash-a sash-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Clem

@sash-a sash-a merged commit a13f0bf into main Mar 5, 2024
5 checks passed
@sash-a sash-a deleted the fix-tests branch March 5, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sash-a sash-a sash-a approved these changes

@djbyrne djbyrne Awaiting requested review from djbyrne

Assignees

@clement-bonnet clement-bonnet

Labels
bug Something isn't working ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clement-bonnet @sash-a