feat(robot_warehouse): full environment #140

arnupretorius · 2023-05-19T09:06:55Z

What?

Full Robotic Warehouse environment code, including random/a2c agents and documentation.

closes #136

CLAassistant · 2023-05-19T09:07:01Z

All committers have signed the CLA.

sash-a

First pass, there's a lot to look through here. So far looking good!

README.md

jumanji/environments/routing/rware/env.py

jumanji/environments/routing/rware/viewer.py

sash-a

Almost done, just need to finish going through utils and env.step. Still looking good!

docs/environments/rware.md

jumanji/environments/routing/rware/env_test.py

jumanji/environments/routing/rware/types.py

jumanji/environments/routing/rware/viewer.py

jumanji/environments/routing/rware/generator.py

jumanji/environments/routing/rware/env.py

sash-a

Looks great (especially types.py)! Only big issue is that I think utils.py needs to be broken up into smaller files, most of the other things are questions/style changes.

jumanji/environments/routing/rware/utils.py

jumanji/environments/routing/rware/env.py

Co-authored-by: Sasha <reallysasha@gmail.com>

sash-a

Thanks for all the changes @arnupretorius looks great! 🔥

README.md

clement-bonnet

Thank you for this large contribution! I spotted a few typos but otherwise good to merge.

jumanji/environments/routing/robot_warehouse/env.py

jumanji/__init__.py

docs/environments/robot_warehouse.md

jumanji/environments/routing/robot_warehouse/generator.py

jumanji/training/networks/robot_warehouse/actor_critic.py

clement-bonnet

Thank you for this large contribution! I spotted a few typos but otherwise good to merge.

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>

arnupretorius added 5 commits May 16, 2023 09:06

feat: initial env code

9884f36

chore: update imports

51aaf16

feat: random agent

07f0101

feat: a2c network

b7a19f8

fix: formatting

3aa8d91

arnupretorius added the enhancement New feature or request label May 19, 2023

arnupretorius self-assigned this May 19, 2023

arnupretorius requested a review from clement-bonnet May 19, 2023 09:07

arnupretorius changed the title ~~136 rware env~~ feat(rware): full environment May 19, 2023

arnupretorius added 4 commits May 19, 2023 13:23

fix: type checker

75fa605

fix: spec test

174f831

feat: docs

8cd6c2c

fix: small typo

c1efe73

sash-a reviewed May 23, 2023

View reviewed changes

README.md Outdated Show resolved Hide resolved

jumanji/environments/routing/rware/env.py Outdated Show resolved Hide resolved

jumanji/environments/routing/rware/env.py Outdated Show resolved Hide resolved

jumanji/environments/routing/rware/env.py Outdated Show resolved Hide resolved

ElshadaiK reviewed May 24, 2023

View reviewed changes

jumanji/environments/routing/rware/env.py Outdated Show resolved Hide resolved

ElshadaiK reviewed May 24, 2023

View reviewed changes

jumanji/environments/routing/rware/viewer.py Outdated Show resolved Hide resolved

ElshadaiK reviewed May 24, 2023

View reviewed changes

jumanji/environments/routing/rware/viewer.py Outdated Show resolved Hide resolved

Merge branch 'main' into 136-rware-env

6c6278a

sash-a reviewed May 24, 2023

View reviewed changes

Merge branch 'main' into 136-rware-env

3bd904e

sash-a requested changes May 25, 2023

View reviewed changes

sash-a and others added 8 commits May 26, 2023 15:02

feat: remove truncation in favour of termination

4014a7d

feat: more layers in network

d52a14f

feat: transformers for rware

f590351

feat: sum embeddings in actor + larger final layer

0471380

fix: critic net

c909ddb

Update docs/environments/rware.md

27d4e62

Co-authored-by: Sasha <reallysasha@gmail.com>

Update jumanji/environments/routing/rware/env_test.py

8341506

Co-authored-by: Sasha <reallysasha@gmail.com>

Update jumanji/environments/routing/rware/env_test.py

63d9265

Co-authored-by: Sasha <reallysasha@gmail.com>

arnupretorius added 2 commits May 30, 2023 18:11

refactor: split utils into separate files

bd2f01e

fix: mypy

abaef2b

sash-a previously approved these changes May 31, 2023

View reviewed changes

README.md Outdated Show resolved Hide resolved

clement-bonnet changed the title ~~feat(rware): full environment~~ feat(robot_warehouse): full environment May 31, 2023

clement-bonnet approved these changes Jun 1, 2023

View reviewed changes

clement-bonnet previously approved these changes Jun 1, 2023

View reviewed changes

Update jumanji/environments/routing/robot_warehouse/env.py

f85b305

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>

arnupretorius dismissed stale reviews from clement-bonnet and sash-a via f85b305 June 1, 2023 08:24

arnupretorius and others added 18 commits June 1, 2023 10:29

Update jumanji/environments/routing/robot_warehouse/env.py

d449cb4

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>

Update jumanji/environments/routing/robot_warehouse/env.py

8a3cd53

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>

Update jumanji/__init__.py

02ea2b2

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>

Update docs/environments/robot_warehouse.md

0d378f1

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>

Update jumanji/environments/routing/robot_warehouse/env.py

c7502f2

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>

Update jumanji/environments/routing/robot_warehouse/generator.py

8688bb0

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>

Update jumanji/environments/routing/robot_warehouse/generator.py

113a3f3

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>

Update jumanji/environments/routing/robot_warehouse/generator.py

a27cc9f

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>

Update jumanji/environments/routing/robot_warehouse/env.py

399d204

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>

Update jumanji/environments/routing/robot_warehouse/env.py

9811268

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>

Update jumanji/environments/routing/robot_warehouse/env.py

5ae26e7

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>

Update jumanji/environments/routing/robot_warehouse/env.py

2396f70

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>

Update jumanji/environments/routing/robot_warehouse/generator.py

55a7980

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>

fix: syntax

220deeb

Update jumanji/training/networks/robot_warehouse/actor_critic.py

97d243e

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>

Update jumanji/training/networks/robot_warehouse/actor_critic.py

7632aab

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>

fix: add abstract properties to generator

796c28a

Merge branch 'main' into 136-rware-env

70175be

clement-bonnet approved these changes Jun 1, 2023

View reviewed changes

clement-bonnet merged commit 26e3e16 into main Jun 1, 2023

clement-bonnet deleted the 136-rware-env branch June 1, 2023 10:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(robot_warehouse): full environment #140

feat(robot_warehouse): full environment #140

arnupretorius commented May 19, 2023 •

edited

Loading

CLAassistant commented May 19, 2023 •

edited

Loading

sash-a left a comment

sash-a left a comment

sash-a left a comment

sash-a left a comment

clement-bonnet left a comment

clement-bonnet left a comment

feat(robot_warehouse): full environment #140

feat(robot_warehouse): full environment #140

Conversation

arnupretorius commented May 19, 2023 • edited Loading

What?

CLAassistant commented May 19, 2023 • edited Loading

sash-a left a comment

Choose a reason for hiding this comment

sash-a left a comment

Choose a reason for hiding this comment

sash-a left a comment

Choose a reason for hiding this comment

sash-a left a comment

Choose a reason for hiding this comment

clement-bonnet left a comment

Choose a reason for hiding this comment

clement-bonnet left a comment

Choose a reason for hiding this comment

arnupretorius commented May 19, 2023 •

edited

Loading

CLAassistant commented May 19, 2023 •

edited

Loading