fix: make autoreset wrapper return 2 on reset #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dluo96
suggested changes
Apr 27, 2023
There was a problem hiding this comment.
Thank you for your contribution @rodSiry! 🚀 This looks good to me! Could you update the PR title to follow the conventional commit style format (see our contribution guidelines) and to be more informative? For example: fix: make autoreset wrapper return 2 on reset.
rodSiry
changed the title
dluo96
previously approved these changes
Apr 27, 2023
clement-bonnet
requested changes
May 2, 2023
dluo96
added
enhancement
clement-bonnet
requested changes
May 5, 2023
clement-bonnet
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the bad autoreset behavior described in issue #106
Now, wrapped environment returns step_type = 2 when resetting.
Adapted corresponding test function, with assert step_type == 2.