New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): single agent #119

Merged

sash-a merged 21 commits into main from feat/single-agent-connector

May 12, 2023

Collaborator

sash-a commented Apr 19, 2023

Changed connector to be a single agent environment.

Changes:

Remove the switch_perspective method.
Changed observation specs
Updated tests
Updated docs

sash-a added 3 commits

April 18, 2023 19:33


          feat: switched connector to single agent

d4111d4


          feat: connector single agent docs

eb1c727


          chore: pre-commit

6da9807

sash-a self-assigned this

sash-a requested a review from clement-bonnet

April 19, 2023 09:03


          chore: better docstring

bd08d67

sash-a changed the title ~~feat (connector): single agent~~ feat(connector): single agent

dluo96 suggested changes

View reviewed changes

Contributor

dluo96 left a comment •

edited

Loading

Thank you for your contribution @sash-a! I have left a few comments 😄

dluo96 reviewed

View reviewed changes

docs/environments/connector.md Outdated Show resolved Hide resolved

dluo96 reviewed

View reviewed changes

jumanji/environments/routing/connector/env.py Outdated Show resolved Hide resolved

dluo96 reviewed

View reviewed changes

jumanji/environments/routing/connector/env.py Outdated Show resolved Hide resolved

dluo96 reviewed

View reviewed changes

jumanji/environments/routing/connector/env.py Show resolved Hide resolved

dluo96 reviewed

View reviewed changes

jumanji/environments/routing/connector/env.py Outdated Show resolved Hide resolved

dluo96 reviewed

View reviewed changes

jumanji/environments/routing/connector/reward.py Outdated Show resolved Hide resolved

dluo96 reviewed

View reviewed changes

jumanji/environments/routing/connector/reward_test.py Outdated Show resolved Hide resolved

sash-a and others added 3 commits

April 24, 2023 11:53


          Apply suggestions from code review

70bbc61

Co-authored-by: Daniel <57721552+dluo96@users.noreply.github.com>


          chore: code review suggestions

5b186c6


          chore: removed more references to multiagent env

0b29198

coyettev reviewed

View reviewed changes

Contributor

coyettev left a comment

Hi Sasha, the PR looks good to me, I just left a few comments 😄

docs/environments/connector.md Outdated Show resolved Hide resolved

jumanji/environments/routing/connector/env.py Outdated Show resolved Hide resolved

jumanji/environments/routing/connector/env.py Outdated Show resolved Hide resolved

jumanji/environments/routing/connector/env_test.py Outdated Show resolved Hide resolved

dluo96 reviewed

View reviewed changes

jumanji/environments/routing/connector/env.py Outdated Show resolved Hide resolved

sash-a and others added 3 commits

May 2, 2023 12:18


          fix: docs and minor test cleanup

c968754


          chore: grammar

316a8a8

Co-authored-by: Daniel <57721552+dluo96@users.noreply.github.com>


          chore: pre-commit

3fcaea5

clement-bonnet requested changes

View reviewed changes

Collaborator

clement-bonnet left a comment •

edited

Loading

Thanks a lot for your contribution.
I have 2 comments/questions:

The registered version of Connector needs to be upped to "Connector-v1".
Have you tried running the A2C network on this? The _make_raw_env function in jumanji/training/setup_train.py must remove the call to MultiToSingleWrapper and the network probably needs to be updated to account for the new observation.

Please let me know if these make sense to you.

jumanji/environments/routing/connector/env.py Outdated Show resolved Hide resolved

jumanji/environments/routing/connector/env.py Outdated Show resolved Hide resolved

jumanji/environments/routing/connector/reward.py Outdated Show resolved Hide resolved

sash-a and others added 6 commits

May 2, 2023 17:44


          Apply suggestions from code review

9526f77

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>


          Merge branch 'main' into feat/single-agent-connector

5307de4


          feat: changed connector version and removed multi-to-single wrapper

648df66


          exp: single agent connector

4c87eb6


          feat: connector trainng working

4a06901


          chore: remove refs to connector-v0

7bcfec2


          Merge branch 'main' into feat/single-agent-connector

94a913e

clement-bonnet reviewed

View reviewed changes

jumanji/training/configs/config.yaml Outdated Show resolved Hide resolved

clement-bonnet reviewed

View reviewed changes

jumanji/training/networks/connector/actor_critic.py Outdated Show resolved Hide resolved

clement-bonnet reviewed

View reviewed changes

jumanji/training/networks/connector/actor_critic.py Outdated Show resolved Hide resolved

sash-a added 2 commits

May 12, 2023 10:18


          fix: connector networks

2c9262b


          chore: revert config

3695cfb

clement-bonnet previously approved these changes

View reviewed changes

Collaborator

clement-bonnet left a comment

Thank you for your contribution. This makes the environment more consistent with the rest of the library! 🚀

jumanji/environments/routing/connector/env.py Show resolved Hide resolved

dluo96 reviewed

View reviewed changes

jumanji/environments/routing/connector/env.py Outdated Show resolved Hide resolved

dluo96 reviewed

View reviewed changes

jumanji/environments/routing/connector/env.py Show resolved Hide resolved

dluo96 reviewed

View reviewed changes

jumanji/training/networks/connector/actor_critic.py Outdated Show resolved Hide resolved

dluo96 reviewed

View reviewed changes

jumanji/training/networks/connector/actor_critic.py Outdated Show resolved Hide resolved

dluo96 reviewed

View reviewed changes

jumanji/training/networks/connector/actor_critic.py Outdated Show resolved Hide resolved

dluo96 previously approved these changes

View reviewed changes

Contributor

dluo96 left a comment

Left a few minor comments and suggestions


          Apply suggestions from code review

c903ff9

Co-authored-by: Daniel <57721552+dluo96@users.noreply.github.com>

sash-a dismissed stale reviews from dluo96 and clement-bonnet via

c903ff9

May 12, 2023 11:10


          chore: grammar and remove comment

998d01c

sash-a enabled auto-merge (squash)

May 12, 2023 12:40

clement-bonnet approved these changes

View reviewed changes

sash-a merged commit e2feb60 into main

sash-a deleted the feat/single-agent-connector branch

May 12, 2023 14:07

clement-bonnet mentioned this pull request

feat(connector): random walk board generator #120

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet