Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: typo in terminal logger #105

Merged
merged 5 commits into from
Mar 29, 2023
Merged

docs: typo in terminal logger #105

merged 5 commits into from
Mar 29, 2023

Conversation

clement-bonnet
Copy link
Collaborator

@clement-bonnet clement-bonnet commented Mar 28, 2023 •
edited
Loading

  • fix typo in terminal logger
  • augment the BinPack doc to clarify that the implemented version is equivalent to 3D-knapsack and not multi-bin packing @RebeccaInstaDeep

@clement-bonnet clement-bonnet added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 28, 2023
@clement-bonnet clement-bonnet requested a review from dluo96 March 28, 2023 19:23
@clement-bonnet clement-bonnet self-assigned this Mar 28, 2023
dluo96
dluo96 approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@dluo96 dluo96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dluo96 dluo96 changed the title Small typo terminal logger docs: typo in terminal logger Mar 29, 2023
@clement-bonnet clement-bonnet merged commit a9c8415 into instadeepai:main Mar 29, 2023
@clement-bonnet clement-bonnet deleted the small-typo-terminal-logger branch August 15, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dluo96 dluo96 dluo96 approved these changes

Assignees

@clement-bonnet clement-bonnet

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clement-bonnet @dluo96