Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle url config for makara connections #93

Merged
merged 2 commits into from
Sep 26, 2015
Merged

Handle url config for makara connections #93

merged 2 commits into from
Sep 26, 2015

Conversation

bf4
Copy link
Contributor

@bf4 bf4 commented Sep 25, 2015

No description provided.

@mnelson
Copy link
Contributor

mnelson commented Sep 26, 2015

Nice, thanks!

mnelson added a commit that referenced this pull request Sep 26, 2015
Handle url config for makara connections
@mnelson mnelson merged commit 186ce6b into instacart:master Sep 26, 2015
@mnelson
Copy link
Contributor

mnelson commented Sep 26, 2015

Oops, didn't notice that most versions were broken. Mind taking a look at those tests?

@mnelson
Copy link
Contributor

mnelson commented Sep 26, 2015

@bf4
Copy link
Contributor Author

bf4 commented Sep 27, 2015

Working on it... :)

B mobile phone

On Sep 26, 2015, at 10:58 AM, Mike Nelson notifications@github.com wrote:

Oops, didn't notice that most versions were broken. Mind taking a look at those tests?


Reply to this email directly or view it on GitHub.

@bf4
Copy link
Contributor Author

bf4 commented Sep 29, 2015

@mnelson updated and pushed. Would you like a new PR for that (assuming it passes, which I expect it to).

bf4 added a commit to bf4/makara that referenced this pull request Sep 29, 2015
@bf4
Copy link
Contributor Author

bf4 commented Sep 29, 2015

Made a followup PR #94

favdev111 pushed a commit to favdev111/makara that referenced this pull request Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants