current and previous contexts are stored in a thread local variable. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we need to check for the existence of the Thread#thread_variable_set and backup to Thread.current#[] if it's not present. |
|
@mnelson Just saw this. We will make these changes soon to be compatible pre 2.0 |
|
Great, thanks. Everything else looks good. |
added 2 commits
May 19, 2015 14:39
…does not respond to thread_variable_(g|s)et methods.
…does not respond to thread_variable_(g|s)et methods. Fix Spelling Error
|
@mnelson I think this is good to go all is green. Please accept if all good. |
mnelson
added a commit
that referenced
this pull request
May 19, 2015
current and previous contexts are stored in a thread local variable.
|
Thanks so much. Merged and up at https://github.com/taskrabbit/makara/releases/tag/v0.3.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context is now thread safe. can be used in a system like sidekiq