Makara::Proxy.new calls super to use SimpleDelegate #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ::ActiveRecord::Base.clear_active_connections! is executed in Rails 3, it calls == on the connection. If initialize does not call super, the == method is not actually sent to the delegate, an ArgumentError: not delegated error is raised. Note that this does not happen in all instances, but is easily reproducible when running Makara in the context of Sidekiq
|
/cc @mattcamuto |
|
Rails 4 looks like it removed any == calls on connections when closing them. We're in progress on updating a Rails 3 app to Rails 4, starting by updating all of our gem dependencies. |
mnelson
added a commit
that referenced
this pull request
May 16, 2015
Makara::Proxy.new calls super to use SimpleDelegate
|
Thanks! |
|
v0.3.2 is up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ::ActiveRecord::Base.clear_active_connections! is executed in Rails 3,
it calls == on the connection. If initialize does not call super, the ==
method is not actually sent to the delegate, an ArgumentError: not delegated
error is raised.
Note that this does not happen in all instances, but is easily reproducible
when running Makara in the context of Sidekiq.