Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace URI.unescape(...) by CGI.unescape(...) #252

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Replace URI.unescape(...) by CGI.unescape(...) #252

merged 1 commit into from
Jan 7, 2021

Conversation

Kevinrob
Copy link
Contributor

@Kevinrob Kevinrob commented Mar 3, 2020

With Ruby 2.7, this line raise warning: URI.unescape is obsolete.

@Kevinrob
Copy link
Contributor Author

Kevinrob commented Mar 4, 2020

ping @bleonard 😊

@bleonard
Copy link
Contributor

bleonard commented Mar 5, 2020

This stuff always got me. Are these the same thing in all cases?
Is it in all rubies?

@Kevinrob
Copy link
Contributor Author

Kevinrob commented Mar 9, 2020

This stuff always got me. Are these the same thing in all cases?
Is it in all rubies?

I just checked the source code. The two functions do the same thing, encoding and pack %... values.
CGI.unescape(...) exists since at least Ruby 2.1.0. What's the minimum version Makara support?

Source of CGI.unescape
Source of URI.unescape (which is more difficult to read because it's depend on DEFAULT_PARSER.unescape)

@ghost
Copy link

ghost commented Apr 14, 2020

Is there a timeline on merging this and cutting a new gem release? 🙏

ghost pushed a commit to stackshareio/makara that referenced this pull request Apr 19, 2020
URI is deprecated
f9cf43a 
Pulled in from instacart#252
montanalow
montanalow approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@montanalow montanalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@montanalow montanalow merged commit fd46b14 into instacart:master Jan 7, 2021
@Kevinrob Kevinrob deleted the URI.unescape_to_CGI.unescape branch January 21, 2021 12:50
@Kevinrob Kevinrob restored the URI.unescape_to_CGI.unescape branch January 21, 2021 12:51
@Kevinrob Kevinrob deleted the URI.unescape_to_CGI.unescape branch February 16, 2021 14:55
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montanalow montanalow montanalow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kevinrob @bleonard @montanalow