Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified gemspec and fixed dependencies across train and train-core. #563

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Unified gemspec and fixed dependencies across train and train-core. #563

merged 1 commit into from
Jan 28, 2020

Conversation

zenspider
Copy link
Contributor

  • train-core has all the real dependencies for train (the project).
  • train keeps all azure/gcp/docker dependencies.
  • train depends on train-core.
  • Removed test_files entirely.
  • Removed FNM_DOTMATCH on our globs... don't cargo cult.
  • Added some code to print out the gemspec and files to make it easier
    to debug by executing the gemspec directly.
  • Sorted all deps... so hard to find things.

Signed-off-by: Ryan Davis zenspider@chef.io

@zenspider zenspider requested a review from a team as a code owner January 24, 2020 23:39
@ghost ghost requested review from clintoncwolfe and miah January 24, 2020 23:39
@chef-expeditor
Copy link
Contributor

Hello zenspider! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

clintoncwolfe
clintoncwolfe approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zenspider zenspider requested a review from tas50 January 27, 2020 20:26
@zenspider
Unified gemspec and fixed dependencies across train and train-core.
322a611 
+ train-core has all the real dependencies for train (the project).
+ train keeps all azure/gcp/docker dependencies.
+ train depends on train-core.
+ Removed test_files entirely.
+ Removed FNM_DOTMATCH on our globs... don't cargo cult.
+ Added some code to print out the gemspec and files to make it easier
  to debug by executing the gemspec directly.
+ Sorted all deps... so hard to find things.

Signed-off-by: Ryan Davis <zenspider@chef.io>
@codeclimate
Copy link

codeclimate bot commented Jan 27, 2020

Code Climate has analyzed commit 322a611 and detected 18 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 18

View more on Code Climate.

@zenspider zenspider merged commit 281254c into master Jan 28, 2020
@chef-expeditor chef-expeditor bot deleted the zenspider/gemspec branch January 28, 2020 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miah miah miah approved these changes

@clintoncwolfe clintoncwolfe clintoncwolfe approved these changes

@tas50 tas50 Awaiting requested review from tas50

Assignees

@zenspider zenspider

Labels
Aspect: Packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zenspider @miah @clintoncwolfe