-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added osx to continuous integration #230
base: master
Are you sure you want to change the base?
Conversation
I will also commit the fix for FreeBSD and OSX in this PR so I won't merge until then |
Seems okay, still need those *BSD fixes though :) |
yeah, we didn't have time to work on it yet :( this PR won't be merged until the darwin build is fixed |
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
==========================================
+ Coverage 73.25% 74.39% +1.13%
==========================================
Files 75 69 -6
Lines 3717 3116 -601
==========================================
- Hits 2723 2318 -405
+ Misses 862 703 -159
+ Partials 132 95 -37
Continue to review full report at Codecov.
|
bd8ef91
to
6846a30
Compare
Signed-off-by: Andrea Barberio <insomniac@slackware.it>
6846a30
to
dc25849
Compare
rebased |
I think BSD was fixed but now we switched to Github CI. Do you want to update this PR? |
As discussed in #229 we need to test on all the OSes we support