Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: forest plot is too wide to save to a4 paper #1026

Closed
3 tasks done
Tracked by #1061
clarkliming opened this issue Aug 9, 2023 · 2 comments · Fixed by #1057
Closed
3 tasks done
Tracked by #1061

[Bug]: forest plot is too wide to save to a4 paper #1026

clarkliming opened this issue Aug 9, 2023 · 2 comments · Fixed by #1057
Assignees
@anajens
Labels
bug Something isn't working priority sme

Comments

@clarkliming
Copy link
Contributor

What happened?

g_forest creates too wide a figure and it doe not fit in a4 paper

image

there is a similar issue like insightsengineering/teal.modules.clinical#724

but for static output we need a4 paper

sessionInfo()

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines.

Security Policy

  • I agree to follow this project's Security Policy.
@clarkliming clarkliming added the bug Something isn't working label Aug 9, 2023
@clarkliming clarkliming mentioned this issue Aug 10, 2023
Closed
@clarkliming
Copy link
Contributor Author

in chevron side, we add some truncation, and also modify the font sizes; it seems to work well now

@clarkliming
Copy link
Contributor Author

sorry to open it again, but maybe it is good to introduce some "fontsize" argument in g_forest to allow easier control of the output

@clarkliming clarkliming reopened this Sep 8, 2023
@anajens anajens self-assigned this Sep 8, 2023
@anajens anajens mentioned this issue Sep 11, 2023
Merged
anajens added a commit that referenced this issue Sep 12, 2023
@anajens
Close #1026: Expose gpar to control graphic settings in g_forest. (#1057
a39ed62 
)

Closes #1026
@shajoezhu shajoezhu mentioned this issue Sep 22, 2023
Closed
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anajens anajens

Labels
bug Something isn't working priority sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close #1026: Expose gpar to control graphic settings in g_forest. insightsengineering/tern
3 participants
@Melkiades @clarkliming @anajens