Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

884 disappear cog icon #886

Merged
merged 1 commit into from
Aug 2, 2023
Merged

884 disappear cog icon #886

merged 1 commit into from
Aug 2, 2023

Conversation

chlebowa
Copy link
Contributor

@chlebowa chlebowa commented Aug 2, 2023

Fixes #884

@chlebowa chlebowa added the core label Aug 2, 2023
@chlebowa chlebowa requested a review from averissimo August 2, 2023 16:45
@chlebowa chlebowa enabled auto-merge (squash) August 2, 2023 16:45
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -----------------------------------------------------------------------------
R/dummy_functions.R                 88      63  28.41%   9-76, 101-104, 107-111
R/get_rcode_utils.R                 46       1  97.83%   49
R/include_css_js.R                  24       0  100.00%
R/init.R                            77      28  63.64%   171-178, 183-204, 216-218
R/module_filter_manager.R          103      29  71.84%   62-70, 79-84, 220, 225-238
R/module_nested_tabs.R             170      16  90.59%   72, 119, 123-124, 138-145, 163, 216, 238, 271
R/module_snapshot_manager.R        140     104  25.71%   71-82, 109-118, 122-134, 136-143, 149-164, 177-200, 203-214, 217-223, 250-273
R/module_tabs_with_filters.R        67       1  98.51%   95
R/module_teal_with_splash.R         33       2  93.94%   65, 77
R/module_teal.R                    164      12  92.68%   68, 71, 158-159, 209-210, 230-233, 235, 239
R/modules_debugging.R               18      18  0.00%    25-44
R/modules.R                        118      17  85.59%   206-211, 330-373
R/reporter_previewer_module.R       16       2  87.50%   23, 27
R/show_rcode_modal.R                20      20  0.00%    16-37
R/tdata.R                           41       2  95.12%   146, 172
R/teal_reporter.R                   60       5  91.67%   65, 116-117, 120, 137
R/teal_slices.R                     45       0  100.00%
R/utils.R                           21       0  100.00%
R/validate_inputs.R                 32       0  100.00%
R/validations.R                     60      37  38.33%   111-373
R/zzz.R                             11       7  36.36%   3-14
TOTAL                             1354     364  73.12%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 136a427

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Unit Tests Summary

    1 files    16 suites   12s ⏱️
171 tests 171 ✔️ 0 💤 0
341 runs  341 ✔️ 0 💤 0

Results for commit 7a134da.

Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Tested in longitudinal application in teal gallery and with small example

@chlebowa chlebowa merged commit 5bbb3aa into main Aug 2, 2023
@chlebowa chlebowa deleted the 884_disappearing_cog@main branch August 2, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug/Question]: Filter manager button shouldn't appear when there are no active datasets
2 participants