Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootstrap vignette #798

Merged
merged 6 commits into from
Jan 13, 2023
Merged

Update bootstrap vignette #798

merged 6 commits into from
Jan 13, 2023

Conversation

asbates
Copy link
Contributor

@asbates asbates commented Jan 11, 2023

Updates the bootstrap theming vignette to add more details on using bslib::run_with_themer to customize a teal application theme. Includes screenshots for each step as well as explanation of how to apply the new theme.

Fixes #738

@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2023

Unit Tests Summary

    1 files    13 suites   14s ⏱️
145 tests 145 ✔️ 0 💤 0
287 runs  287 ✔️ 0 💤 0

Results for commit 866989f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2023

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  ------------------------------
R/dummy_functions.R                 74      61  17.57%   12-95
R/example_module.R                  18       9  50.00%   23-26, 29-33
R/get_rcode_utils.R                 52       2  96.15%   94, 99
R/get_rcode.R                      137      54  60.58%   74, 81, 86, 211-277
R/include_css_js.R                  24       0  100.00%
R/init.R                            22       2  90.91%   188-189
R/module_nested_tabs.R             130       7  94.62%   57, 96, 101-102, 148, 198, 227
R/module_tabs_with_filters.R        68       1  98.53%   162
R/module_teal_with_splash.R         33       2  93.94%   65, 77
R/module_teal.R                    111       5  95.50%   49, 52, 155-156, 180
R/modules_debugging.R               18      18  0.00%    37-56
R/modules.R                        101       8  92.08%   341-366
R/reporter_previewer_module.R       12       2  83.33%   18, 22
R/show_rcode_modal.R                20      20  0.00%    17-38
R/tdata.R                           41       2  95.12%   146, 172
R/utils.R                           13       0  100.00%
R/validate_inputs.R                 21       0  100.00%
R/validations.R                     62      39  37.10%   107-368
R/zzz.R                             11       7  36.36%   3-14
TOTAL                              968     239  75.31%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: a5ef518

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

@donyunardi donyunardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contents are good.
One small request, can we do a better circle annotation on the images/screenshots?
In Mac, I could do this using Preview.
I think in Windows you can do something like MS Paint?

@asbates
Copy link
Contributor Author

asbates commented Jan 12, 2023

The contents are good. One small request, can we do a better circle annotation on the images/screenshots? In Mac, I could do this using Preview. I think in Windows you can do something like MS Paint?

You don't like my masterful hand drawing? :). Do these new images look better?

asbates and others added 3 commits January 12, 2023 15:39
Signed-off-by: Andrew Bates <andrewbates73@gmail.com>
@nikolas-burkoff nikolas-burkoff enabled auto-merge (squash) January 13, 2023 10:28
@nikolas-burkoff nikolas-burkoff merged commit 00d1dba into main Jan 13, 2023
@nikolas-burkoff nikolas-burkoff deleted the 738_bs_vignette@main branch January 13, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance vignette for Bootstrap when using run_with_themer and bs_theme_update
3 participants