Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove soft-deprecated function log_app_usage and .log #781

Merged
merged 8 commits into from
Nov 22, 2022
Merged

Remove soft-deprecated function log_app_usage and .log #781

merged 8 commits into from
Nov 22, 2022

Conversation

chlebowa
Copy link
Contributor

Closes this issue.

Removed source and updated documentation.

@chlebowa chlebowa added the core label Nov 21, 2022
@chlebowa chlebowa marked this pull request as ready for review November 21, 2022 10:56
@chlebowa chlebowa enabled auto-merge (squash) November 21, 2022 10:56
@chlebowa chlebowa requested a review from donyunardi November 21, 2022 10:57
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2022 •
edited
Loading

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -------------------------------------------
R/dummy_functions.R                 74      61  17.57%   12-95
R/example_module.R                  18      18  0.00%    19-36
R/get_rcode_utils.R                 52       2  96.15%   94, 99
R/get_rcode.R                      137      54  60.58%   74, 81, 86, 211-277
R/include_css_js.R                  24       0  100.00%
R/init.R                            39      21  46.15%   173, 184-185, 238-259
R/module_nested_tabs.R             130       7  94.62%   57, 96, 101-102, 148, 198, 227
R/module_tabs_with_filters.R        68       1  98.53%   160
R/module_teal_with_splash.R         33       2  93.94%   62, 74
R/module_teal.R                    131      20  84.73%   49, 52, 155-156, 169-175, 181-187, 210, 240
R/modules_debugging.R               18      18  0.00%    39-58
R/modules.R                        101       8  92.08%   341-366
R/reporter_previewer_module.R       12       2  83.33%   18, 22
R/show_rcode_modal.R                20      20  0.00%    17-38
R/tdata.R                           41       2  95.12%   146, 172
R/utils.R                           13       0  100.00%
R/validations.R                     62      39  37.10%   103-355
R/zzz.R                             11       7  36.36%   3-14
TOTAL                              984     282  71.34%

Diff against main

Filename    Stmts    Miss    Cover
----------  -------  ------  -------
TOTAL       -        -       +3.52%

Results for commit: e190189

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Aleksander Chlebowski added 2 commits November 21, 2022 13:10
nikolas-burkoff
nikolas-burkoff approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment in pkgdown file but then all good

_pkgdown.yml
desc: These functions have been moved from teal and will be deprecated.
contents:
- log_app_usage
# - title: Functions moved to other packages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets just remove these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to leave it in case it comes up again to keep the format of the pkgdown output.

@nikolas-burkoff nikolas-burkoff self-assigned this Nov 22, 2022
@github-actions
Copy link
Contributor

Unit Tests Summary

    1 files    12 suites   11s ⏱️
135 tests 135 ✔️ 0 💤 0 ❌
257 runs  257 ✔️ 0 💤 0 ❌

Results for commit bd0a88d.

@chlebowa chlebowa merged commit bfbe5af into main Nov 22, 2022
@chlebowa chlebowa deleted the 755_remove_deprecated@main branch November 22, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolas-burkoff nikolas-burkoff nikolas-burkoff approved these changes

@donyunardi donyunardi Awaiting requested review from donyunardi

Assignees

@nikolas-burkoff nikolas-burkoff

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove soft-deprecated function log_app_usage and .log
2 participants
@chlebowa @nikolas-burkoff