teal - bs345 #727
teal - bs345 #727
Conversation
|
@nikolas-burkoff thanks for comments, during our call:) |
Co-authored-by: Nikolas Burkoff <nikolas.burkoff@roche.com>
R/utils.R
Outdated
| #' Resolve the expected bootstrap version | ||
| #' @keywords internal | ||
| get_teal_bs_version <- function() { |
There was a problem hiding this comment.
It would be good to support both R option as well as sys env. I would say that for the app users the latter one is more accessible through the config panel in RSConnect. That's true for each of our settings.
If added, please explain the order in the docs / vignette. A good example could be found here: https://rstudio.github.io/renv/reference/config.html#details
There was a problem hiding this comment.
actually it is true for only settings that could be expressed as a character
There was a problem hiding this comment.
We could not support sys env as we are expecting bslib::bs_theme which is quite complex object. sys env supports only base types like string.
adding test cases to increase coverage
cicdguy
force-pushed
the
709_bs345@main
branch
from
8c92de7 to
997c3d1
Compare
|
lgtm |
linked to #719