Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DESC and README #684

Merged
merged 5 commits into from
Jul 7, 2022
Merged

DESC and README #684

merged 5 commits into from
Jul 7, 2022

Conversation

denisovan31415
Copy link
Contributor

@denisovan31415 denisovan31415 commented Jul 6, 2022 •
edited by nikolas-burkoff
Loading

part of #668

Also closes #686

@denisovan31415 denisovan31415 mentioned this pull request Jul 6, 2022
Closed
22 tasks
nikolas-burkoff
nikolas-burkoff reviewed Jul 7, 2022
View reviewed changes
DESCRIPTION Outdated Show resolved Hide resolved
nikolas-burkoff
nikolas-burkoff approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nikolas-burkoff nikolas-burkoff self-assigned this Jul 7, 2022
nikolas-burkoff
nikolas-burkoff reviewed Jul 7, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022 •
edited
Loading

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -----------------------------------------------
R/default_filter.R                   7       7  0.00%    17-27
R/dummy_functions.R                 74      61  17.57%   12-95
R/example_module.R                  17      17  0.00%    19-35
R/get_rcode_utils.R                 52       2  96.15%   94, 99
R/get_rcode.R                      131      40  69.47%   66, 73, 78, 212-261
R/include_css_js.R                  20       0  100.00%
R/init.R                            39      21  46.15%   171, 182-183, 236-257
R/log_app_usage.R                   38      38  0.00%    34-119
R/logging.R                         13      13  0.00%    11-28
R/module_nested_tabs.R             110      15  86.36%   57, 96, 115-127, 163, 212, 252
R/module_tabs_with_filters.R        52      21  59.62%   111-137
R/module_teal_with_splash.R         33       2  93.94%   62, 74
R/module_teal.R                    119      28  76.47%   49, 52, 142-143, 156-162, 168-174, 197, 227-239
R/modules_debugging.R               19      19  0.00%    41-60
R/modules.R                        109      10  90.83%   218, 287, 415-440
R/reporter_previewer_module.R       12       2  83.33%   18, 22
R/show_rcode_modal.R                20      20  0.00%    17-38
R/utils.R                            6       0  100.00%
R/validations.R                     62      39  37.10%   103-355
R/zzz.R                             11       7  36.36%   3-14
TOTAL                              944     362  61.65%

Results for commit: 65daaec

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022 •
edited
Loading

Unit Tests Summary

    1 files    10 suites   10s ⏱️
104 tests 104 ✔️ 0 💤 0 ❌
205 runs  205 ✔️ 0 💤 0 ❌

Results for commit 56ecf81.

♻️ This comment has been updated with latest results.

Polkas
Polkas reviewed Jul 7, 2022
View reviewed changes
tests/testthat/test-get_rcode.R
testthat::expect_identical(
get_rcode(chunks = ch),
sprintf("\n\n%s\n", paste(get_rcode_header(), collapse = "\n"))
strsplit(r_code_from_chunks, "\n")[[1]][c(1:5, 7:14)],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤡 if works then it works`:D

@nikolas-burkoff nikolas-burkoff merged commit 2c5f1a7 into main Jul 7, 2022
@nikolas-burkoff nikolas-burkoff deleted the 668_install@main branch July 7, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolas-burkoff nikolas-burkoff nikolas-burkoff approved these changes

@Polkas Polkas Polkas approved these changes

Assignees

@nikolas-burkoff nikolas-burkoff

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix unstable test
3 participants
@denisovan31415 @Polkas @nikolas-burkoff