Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tests to check the new features of teal_data_module #1293

Merged

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Aug 6, 2024

Added tests to check the two new features of the teal_data_module:

  1. Now teal_data_module can have once argument.
  2. The module tabs are disabled when teal_data_module is not loaded.

@vedhav vedhav mentioned this pull request Aug 6, 2024
63 tasks
@m7pr m7pr self-assigned this Aug 6, 2024
@m7pr
Copy link
Contributor

m7pr commented Aug 6, 2024

I think I see one test failining, and I think that's the one you edited

> devtools::test()
ℹ Testing teal
[INFO] 2024-08-06 17:26:48.7668 pid:29860 token:[] teal You are using teal version 0.15.2.9050| F W  S  OK | Context|      1   9 | init [2.6s]                                             
✔ |      1 120 | module_teal [50.3s]                                     
✔ |         95 | modules|          7 | rcode_utils|          5 | report_previewer_module| 1        5 | shinytest2-data_summary [41.2s]                         
─────────────────────────────────────────────────────────────────────────
Failure (test-shinytest2-data_summary.R:121:5): e2e: data summary is displayed properly if teal_data include data.frames with join keys, MAE objects and vectors
as.data.frame(app$get_active_data_summary_table()) not identical to data.frame(...).
Attributes: < Componentrow.names: Numeric: lengths (10, 11) differ >
ComponentData Name: Lengths (10, 11) differ (string compare on first 10)
ComponentData Name: 10 string mismatches
ComponentObs: Lengths (10, 11) differ (string compare on first 10)
ComponentObs: 9 string mismatches
ComponentSubjects: Lengths (10, 11) differ (string compare on first 10)
ComponentSubjects: 9 string mismatches

Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vedhav overall looks great. Made few suggestions - please have a look.
Blocking because you used |> pipe operator. teal is based on R 4.0.0 where pipe was introduced in R 4.1.0. Please update tests

vedhav and others added 5 commits August 7, 2024 10:03
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: Vedha Viyash <49812166+vedhav@users.noreply.github.com>
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: Vedha Viyash <49812166+vedhav@users.noreply.github.com>
Signed-off-by: Vedha Viyash <49812166+vedhav@users.noreply.github.com>
@vedhav vedhav requested a review from m7pr August 7, 2024 05:06
Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vedhav I still see |>. Please check my previous comment on the issue

Signed-off-by: Vedha Viyash <49812166+vedhav@users.noreply.github.com>
@vedhav
Copy link
Contributor Author

vedhav commented Aug 7, 2024

Thanks! Removed it.

@vedhav vedhav requested a review from m7pr August 7, 2024 07:17
@m7pr
Copy link
Contributor

m7pr commented Aug 7, 2024

Great work @vedhav ! You are ready to merge this

@vedhav vedhav merged commit 2a3780f into 669_insertUI@main Aug 7, 2024
1 check passed
@vedhav vedhav deleted the extend-teal_data_module-tests@669_insertUI@main branch August 7, 2024 08:14
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants