-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds tests to check the new features of teal_data_module #1293
Adds tests to check the new features of teal_data_module #1293
Conversation
I think I see one test failining, and I think that's the one you edited > devtools::test()
ℹ Testing teal
[INFO] 2024-08-06 17:26:48.7668 pid:29860 token:[] teal You are using teal version 0.15.2.9050
✔ | F W S OK | Context
✔ | 1 9 | init [2.6s]
✔ | 1 120 | module_teal [50.3s]
✔ | 95 | modules
✔ | 7 | rcode_utils
✔ | 5 | report_previewer_module
✖ | 1 5 | shinytest2-data_summary [41.2s]
─────────────────────────────────────────────────────────────────────────
Failure (test-shinytest2-data_summary.R:121:5): e2e: data summary is displayed properly if teal_data include data.frames with join keys, MAE objects and vectors
as.data.frame(app$get_active_data_summary_table()) not identical to data.frame(...).
Attributes: < Component “row.names”: Numeric: lengths (10, 11) differ >
Component “Data Name”: Lengths (10, 11) differ (string compare on first 10)
Component “Data Name”: 10 string mismatches
Component “Obs”: Lengths (10, 11) differ (string compare on first 10)
Component “Obs”: 9 string mismatches
Component “Subjects”: Lengths (10, 11) differ (string compare on first 10)
Component “Subjects”: 9 string mismatches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vedhav overall looks great. Made few suggestions - please have a look.
Blocking because you used |>
pipe operator. teal
is based on R 4.0.0
where pipe was introduced in R 4.1.0
. Please update tests
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com> Signed-off-by: Vedha Viyash <49812166+vedhav@users.noreply.github.com>
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com> Signed-off-by: Vedha Viyash <49812166+vedhav@users.noreply.github.com>
Signed-off-by: Vedha Viyash <49812166+vedhav@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vedhav I still see |>
. Please check my previous comment on the issue
Signed-off-by: Vedha Viyash <49812166+vedhav@users.noreply.github.com>
Thanks! Removed it. |
Great work @vedhav ! You are ready to merge this |
Added tests to check the two new features of the
teal_data_module
:teal_data_module
can haveonce
argument.teal_data_module
is not loaded.