Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assertion and docs #94

Merged
merged 7 commits into from
Aug 22, 2022
Merged

Fix assertion and docs #94

merged 7 commits into from
Aug 22, 2022

Conversation

gogonzo
Copy link
Contributor

@gogonzo gogonzo commented Aug 19, 2022

closes insightsengineering/teal.modules.clinical#568
fix

  • list of data extract spec can be NULL also because data_extract_multiple handles this situation by not processing this item
    data_extract <- Filter(Negate(is.null), data_extract)

SO the data_merge_module, merge_expression_module, data_extract_multiple_srv can accept empty list element

Branch is 26_new_chunks@main but the change qualifies to main

@gogonzo gogonzo added the core label Aug 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2022

Unit Tests Summary

    1 files    24 suites   56s ⏱️
193 tests 192 ✔️ 1 💤 0
668 runs  667 ✔️ 1 💤 0

Results for commit 1292295.

♻️ This comment has been updated with latest results.

R/data_merge_module.R Outdated Show resolved Hide resolved
R/merge_expression_module.R Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2022

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ---------------------------------------------------------------------
R/all_choices.R                       1       0  100.00%
R/call_utils.R                      156     124  20.51%   14-23, 64, 66, 68, 107-431
R/check_selector.R                   31       0  100.00%
R/choices_labeled.R                 202      61  69.80%   60, 71, 76, 87, 103, 221-225, 229-234, 264-277, 390-391, 393, 425-473
R/choices_selected.R                 81      11  86.42%   201-229, 260
R/column_functions.R                  3       3  0.00%    13-16
R/data_extract_datanames.R           32       8  75.00%   9-13, 64-66
R/data_extract_filter_module.R       92      11  88.04%   75-82, 84, 87-88, 141
R/data_extract_module.R             247      61  75.30%   3, 121, 126, 143, 146-151, 153, 172-175, 203-249, 446, 451, 482, 585
R/data_extract_read_module.R        122      13  89.34%   28, 32-35, 102-107, 116, 133
R/data_extract_select_module.R       32      18  43.75%   31-48
R/data_extract_single_module.R       53       2  96.23%   29, 42
R/data_extract_spec.R                32       0  100.00%
R/data_merge_module.R                58      15  74.14%   101-118
R/filter_spec.R                     186       1  99.46%   373
R/format_data_extract.R              16       1  93.75%   49
R/get_dplyr_call.R                  299       0  100.00%
R/get_merge_call.R                  280      29  89.64%   28-34, 45, 206-215, 368, 384-396
R/include_css_js.R                    5       0  100.00%
R/input_checks.R                     11       2  81.82%   18-19
R/merge_data_utils.R                  2       0  100.00%
R/merge_datasets.R                  135       6  95.56%   77, 225-229
R/merge_expression_module.R          46       1  97.83%   147
R/resolve_delayed.R                  16       0  100.00%
R/resolve.R                         114      44  61.40%   229-312
R/select_spec.R                      49       8  83.67%   149, 213-220
R/utils.R                            15      11  26.67%   26-39
R/zzz.R                               2       2  0.00%    2-3
TOTAL                              2318     432  81.36%

Results for commit: f470f14

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

@Polkas Polkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
data_merge_srv -> ds <- Filter(Negate(is.null), lapply(selector_list(), function(x) x()))

data_extract_multiple_srv.FilteredData -> data_extract_multiple_srv.list -> data_extract <- Filter(Negate(is.null), data_extract)

@gogonzo gogonzo merged commit cb190fd into main Aug 22, 2022
@gogonzo gogonzo deleted the 26_new_chunks@main branch August 22, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tm_g_pp_adverse_events - empty decod variable
2 participants