Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add roxy.shinylive to DESCRIPTION and vignettes, update NEWS #249

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

donyunardi
Copy link
Contributor

Addressing this comment:
#248 (review)

I'm creating a separate PR to merge the vignettes into the main branch first so they can be built before moving forward with the release.

Summary

  • Update all vignettes to include shinylive
  • Update NEWS
  • Add roxy.shinylive to Suggest

For this comment:

while some where from log_warn to warning (resolve.delayed_value_choices()).

I decided not to add to NEWS because the affected function is internal.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Unit Tests Summary

  1 files   24 suites   6s ⏱️
194 tests 194 ✅ 0 💤 0 ❌
697 runs  697 ✅ 0 💤 0 ❌

Results for commit 9c8a1e2.

♻️ This comment has been updated with latest results.

@llrs-roche llrs-roche self-assigned this Feb 5, 2025
DESCRIPTION Outdated Show resolved Hide resolved
Copy link

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the comment from Martin this looks good. I appreciate that chunk labels were added. And that shinylives apps are only added if many conditions are met. Note that the spelling check fails, the dictionary might need to be updated.

donyunardi and others added 2 commits February 5, 2025 16:52
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: Dony Unardi <donyunardi@gmail.com>
@donyunardi donyunardi enabled auto-merge (squash) February 6, 2025 04:09
@donyunardi donyunardi merged commit 93b24d7 into main Feb 6, 2025
28 of 29 checks passed
@donyunardi donyunardi deleted the update_vignettes_news@main branch February 6, 2025 04:13
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants