Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor changes. #197

Merged
merged 7 commits into from
Feb 14, 2024
Merged

minor changes. #197

merged 7 commits into from
Feb 14, 2024

Conversation

kartikeyakirar
Copy link
Contributor

part of #176

I have made minor updates as part of review process

  • updated document
  • changed tags
  • added some punctuations
  • removed unused variable.

@averissimo averissimo self-assigned this Feb 14, 2024
@kartikeyakirar
merge back from pre-release
17db8f1 
Merge branch '178_pre-release-cleanup@main' into minor_update@178_pe-release-cleanup@main

# Conflicts:
#	R/choices_selected.R
#	man/choices_selected.Rd
@kartikeyakirar kartikeyakirar mentioned this pull request Feb 14, 2024
Merged
27 tasks
averissimo
averissimo reviewed Feb 14, 2024
View reviewed changes
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, left some comments that may require a bit of discussion.

Do you want to huddle for a fast resolution?

R/choices_labeled.R Show resolved Hide resolved
R/choices_selected.R Outdated Show resolved Hide resolved
R/get_merge_call.R Outdated Show resolved Hide resolved
R/include_css_js.R Show resolved Hide resolved
R/merge_expression_module.R Outdated Show resolved Hide resolved
kartikeyakirar and others added 5 commits February 14, 2024 19:18
@kartikeyakirar @averissimo
Update R/choices_selected.R
a05d661 
Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
@kartikeyakirar @averissimo
Update R/get_merge_call.R
6395f66 
Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
@kartikeyakirar @averissimo
Update R/merge_expression_module.R
ca62901 
Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
@kartikeyakirar
removing return tag
891271c
@kartikeyakirar
Merge branch 'minor_update@178_pe-release-cleanup@main' of https://gi…
c85dd9a 
…thub.com/insightsengineering/teal.transform into minor_update@178_pe-release-cleanup@main
averissimo
averissimo approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kartikeyakirar kartikeyakirar merged commit 8296b88 into 178_pre-release-cleanup@main Feb 14, 2024
@kartikeyakirar kartikeyakirar deleted the minor_update@178_pe-release-cleanup@main branch February 14, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averissimo averissimo averissimo approved these changes

Assignees

@averissimo averissimo

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kartikeyakirar @averissimo