Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

145 remove cdisc from teal.slice::init_filter_data in tests #146

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jul 17, 2023

Closes #145

@m7pr m7pr added the core label Jul 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023

Unit Tests Summary

    1 files    25 suites   8s ⏱️
207 tests 206 ✔️ 1 💤 0
708 runs  707 ✔️ 1 💤 0

Results for commit 4699981.

♻️ This comment has been updated with latest results.

@m7pr m7pr marked this pull request as draft July 17, 2023 15:43
@gogonzo gogonzo marked this pull request as ready for review July 17, 2023 16:15
@gogonzo gogonzo self-assigned this Jul 17, 2023
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ------------------------------------------------------------------------
R/all_choices.R                       1       0  100.00%
R/call_utils.R                      156     124  20.51%   14-23, 64, 66, 68, 107-431
R/check_selector.R                   31       0  100.00%
R/choices_labeled.R                 200      54  73.00%   59, 65, 70, 77, 93, 215-219, 223-228, 258-271, 383-384, 386, 434-466
R/choices_selected.R                 81      11  86.42%   200-228, 259
R/column_functions.R                  3       3  0.00%    13-16
R/data_extract_datanames.R           32       8  75.00%   9-13, 64-66
R/data_extract_filter_module.R       95      16  83.16%   75-88, 90-91, 145
R/data_extract_module.R             298      66  77.85%   3, 115, 120, 137, 140-145, 147, 166-169, 197-243, 476, 481, 660, 726-731
R/data_extract_read_module.R        135       7  94.81%   29, 33-36, 131, 148
R/data_extract_select_module.R       32      18  43.75%   31-48
R/data_extract_single_module.R       53       2  96.23%   29, 42
R/data_extract_spec.R                32       0  100.00%
R/data_merge_module.R                61      15  75.41%   101-118
R/filter_spec.R                     186       1  99.46%   302
R/format_data_extract.R              16       1  93.75%   49
R/get_dplyr_call.R                  299       0  100.00%
R/get_merge_call.R                  280      29  89.64%   28-34, 45, 206-215, 369, 385-397
R/include_css_js.R                    5       0  100.00%
R/input_checks.R                     11       2  81.82%   18-19
R/merge_data_utils.R                  2       0  100.00%
R/merge_datasets.R                  135       6  95.56%   77, 225-229
R/merge_expression_module.R          49       1  97.96%   147
R/Queue.R                            23       0  100.00%
R/resolve_delayed.R                  16       0  100.00%
R/resolve.R                         114      44  61.40%   227-310
R/select_spec.R                      49       8  83.67%   103, 167-174
R/utils.R                            24      11  54.17%   26-39
R/zzz.R                               2       2  0.00%    2-3
TOTAL                              2421     429  82.28%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 1ca65c2

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@gogonzo gogonzo closed this Jul 17, 2023
@gogonzo gogonzo reopened this Jul 17, 2023
@gogonzo gogonzo enabled auto-merge (squash) July 17, 2023 16:30
@gogonzo gogonzo merged commit 4764b03 into main Jul 17, 2023
@gogonzo gogonzo deleted the 145_remove_cdisc@main branch July 17, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

teal.transform fails after filter_panel_refactor@main was merged to teal.slice
2 participants