Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

choices.labeled: update length and docs #108

Merged
merged 3 commits into from
Nov 18, 2022
Merged

Conversation

mhallal1
Copy link
Contributor

@mhallal1 mhallal1 commented Nov 18, 2022

fixes errors in choices.labeled:
image

R CMD CHECK checked in both teal.modules.general and teal.modules.clinical.

@mhallal1 mhallal1 added the core label Nov 18, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2022

Unit Tests Summary

    1 files    24 suites   54s ⏱️
193 tests 192 ✔️ 1 💤 0
669 runs  668 ✔️ 1 💤 0

Results for commit f76e966.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2022

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  --------------------------------------------------------------------
R/all_choices.R                       1       0  100.00%
R/call_utils.R                      156     124  20.51%   14-23, 64, 66, 68, 107-431
R/check_selector.R                   31       0  100.00%
R/choices_labeled.R                 200      61  69.50%   60, 66, 71, 78, 94, 218-222, 226-231, 261-274, 388-389, 391, 423-471
R/choices_selected.R                 81      11  86.42%   201-229, 260
R/column_functions.R                  3       3  0.00%    13-16
R/data_extract_datanames.R           32       8  75.00%   9-13, 64-66
R/data_extract_filter_module.R       92      11  88.04%   75-82, 84, 87-88, 141
R/data_extract_module.R             247      61  75.30%   3, 121, 126, 143, 146-151, 153, 172-175, 203-249, 446, 451, 482, 585
R/data_extract_read_module.R        123      13  89.43%   28, 32-35, 103-108, 117, 134
R/data_extract_select_module.R       32      18  43.75%   31-48
R/data_extract_single_module.R       53       2  96.23%   29, 42
R/data_extract_spec.R                32       0  100.00%
R/data_merge_module.R                58      15  74.14%   101-118
R/filter_spec.R                     186       1  99.46%   373
R/format_data_extract.R              16       1  93.75%   49
R/get_dplyr_call.R                  299       0  100.00%
R/get_merge_call.R                  280      29  89.64%   28-34, 45, 206-215, 368, 384-396
R/include_css_js.R                    5       0  100.00%
R/input_checks.R                     11       2  81.82%   18-19
R/merge_data_utils.R                  2       0  100.00%
R/merge_datasets.R                  135       6  95.56%   77, 225-229
R/merge_expression_module.R          46       1  97.83%   147
R/resolve_delayed.R                  16       0  100.00%
R/resolve.R                         114      44  61.40%   229-312
R/select_spec.R                      49       8  83.67%   149, 213-220
R/utils.R                            15      11  26.67%   26-39
R/zzz.R                               2       2  0.00%    2-3
TOTAL                              2317     432  81.36%

Diff against main

Filename               Stmts  Miss    Cover
-------------------  -------  ------  -------
R/choices_labeled.R       -5  -       -0.74%
TOTAL                     -5  -       -0.04%

Results for commit: 9906974

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@chlebowa
Copy link
Contributor

Add rlang::local_options(lifecycle_verbosity = "quiet") in unit tests to silence deprecation warning.

R/choices_labeled.R Outdated Show resolved Hide resolved
mhallal1 and others added 2 commits November 18, 2022 13:58
Co-authored-by: Dawid Kałędkowski <6959016+gogonzo@users.noreply.github.com>
Signed-off-by: Mahmoud Hallal <86970066+mhallal1@users.noreply.github.com>
@mhallal1 mhallal1 merged commit 57da485 into main Nov 18, 2022
@mhallal1 mhallal1 deleted the choices_labeled_fix@main branch November 18, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants