Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1033 drop support for list filter #517

Conversation

chlebowa
Copy link
Contributor

@chlebowa chlebowa added the core label Jan 11, 2024
@chlebowa chlebowa changed the title 1033 dro psupport for list filter 1033 drop support for list filter Jan 11, 2024
@gogonzo gogonzo self-assigned this Jan 11, 2024
@donyunardi donyunardi mentioned this pull request Jan 11, 2024
34 tasks
Copy link
Contributor

@pawelru pawelru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the docs accordingly:

#' @param state (`named list`)\cr
#' names of the list should correspond to the names of the initialized `FilterStates`
#' kept in `private$filter_states`. For this object they are `"subjects"` and
#' names of the experiments. Values of initial state should be relevant
#' to the referred column.

teal.slice/R/FilterStates.R

Lines 247 to 250 in ea69177

#' @param state (`named list`)\cr
#' should contain values which are initial selection in the `FilterState`.
#' Names of the `list` element should correspond to the name of the
#' column in `data`.

@pawelru pawelru self-requested a review January 15, 2024 13:33
@pawelru
Copy link
Contributor

pawelru commented Jan 15, 2024

Sorry - my previous comment was unrelated - it was about docs for teal_slices and not teal_slice

@chlebowa chlebowa merged commit 806ad2c into pre-release-cleanup@main Jan 15, 2024
@chlebowa chlebowa deleted the 1033_drop_list_filter@pre-release-cleanup@main branch January 15, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support of list class for filter argument
3 participants