Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove examples for non-exported functions #548

Closed
chlebowa opened this issue Jan 31, 2024 · 2 comments · Fixed by #550
Closed

remove examples for non-exported functions #548

chlebowa opened this issue Jan 31, 2024 · 2 comments · Fixed by #550
Assignees
@m7pr
Labels
core

Comments

@chlebowa
Copy link
Contributor

Examples for non-exported functions should be removed before the initial CRAN release and restored afterwards.
The Examples in question can be easily identified as they all contain getFromNamespace calls.

Remove them all in one commit (can be a squash commit of a PR) so that it can be easily reverted.
@chlebowa chlebowa added the core label Jan 31, 2024
@donyunardi donyunardi mentioned this issue Jan 31, 2024
Closed
34 tasks
@m7pr
Copy link
Contributor

m7pr commented Feb 1, 2024

I'm on it

@m7pr m7pr self-assigned this Feb 1, 2024
@m7pr m7pr mentioned this issue Feb 1, 2024
Merged
@averissimo averissimo mentioned this issue Feb 5, 2024
Closed
m7pr added a commit that referenced this issue Feb 5, 2024
@m7pr
548 remove private/internal examples (#550)
db4e789 
Closes #548
@m7pr
Copy link
Contributor

m7pr commented Feb 5, 2024

Clossed with #550

@m7pr m7pr closed this as completed Feb 5, 2024
cicdguy pushed a commit that referenced this issue Feb 6, 2024
@m7pr @cicdguy
548 remove private/internal examples (#550)
7af6b37 
Closes #548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m7pr m7pr

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

548 remove private/internal examples insightsengineering/teal.slice
2 participants
@chlebowa @m7pr