internal function topological_sort() is defined in teal.slice and teal.data

[kartikeyakirar]

What happened?

The topological_sort function is defined in both the teal.slice and teal.data packages, sharing identical logic.

Should we utilize it in teal.slice by employing the getFromNamespace() function (pending feedback from CRAN for teal.code)? Alternatively, do we consider exporting this function in teal.data?

[chlebowa]

I assume you mean to place the getNamespace call in zzz.R in teal.slice like we do in teal.
While it would reduce code duplication and make changes easier, teal Depends on teal.data but teal.slice Imports teal.data. I am in two minds about this.

[kartikeyakirar]

I assume you mean to place the getNamespace call in zzz.R in teal.slice like we do in teal

Yes, however , the presence of the 'teal.data' package in the import section of 'teal.slice' triggers a note on check().

[chlebowa]

I don't see how this is related.

[kartikeyakirar]

my mistake, I am getting this note because the function getFromNamespace() not because of the package is in import.