-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Nicer table formatting in PPT outputs #185
Comments
Acceptance criteria: Research the Ensure font sizes in reports are more suitable. |
NOTE: Feel free to separate into 2 issues if research and implementation are too much. |
Is there a consideration about converting into flextable object and work from there for nicer formats? |
I'm having difficulty finding the |
@kartikeyakirar Package is located in internal repos and not yet published externally. I will share link privately. |
Hey @donyunardi and @lcd2yyz In autoslideR there custom color-based theme for flextable, which isn't exactly the same as what's displayed on the dashboard but does enhance the overall look for reporting purposes. We'd like your input on whether we should include this theme or stick with the simpler format shown on the dashboard. |
Personally, I would like to keep the format as simple as possible. I believe that coloring is a matter of personal preference, and users can change it themselves later if they wish. On the simple format shown in the dashboard, can we add an outer border and a horizontal line in the inner output? I was reading about flextable, and it looks like we can do something like this: If we can, then I think it will further improve the looks when we keep it simple. |
Agree with @donyunardi to keep it simple. |
@lcd2yyz and @donyunardi, I appreciate your valuable feedback. I have implemented some changes using theme_booktabs(), including the addition of borders and horizontal lines. You can see the updated format in this image: Furthermore, I've introduced an additional issue/feature request as an extension to the one we discussed earlier. You can find more details here: #212 |
Looking very nice! |
Flextables can be fully edited in both PowerPoint and document formats. Screen.Recording.2023-09-09.at.12.15.23.AM.mov |
It's wonderful to see this change as user from study team who wants to use this feature for future slides preparation! I did a similar way to allow the tables as shown as flextable by only altering in Renderer.R: |
@puzeng Accommodating a very lengthy table within a single slide is extremely challenging , and it's nearly impossible to adjust such a substantial amount of content in a single slide. Manual editing may be helpful in certain scenarios. Here is the table: table_20230911_114923.pdf. This is a demonstration of how this content is displayed in a slide Screen.Recording.2023-09-11.at.11.55.27.AM.mov |
Hi @puzeng, I agree with @kartikeyakirar that enabling pagination will be quite challenging at this point, given that If you still feel strongly about this feature, please open an new issue, with your suggested approach and/or example code, if you already have it. Then we'll consider for future development. |
this PR fixes #185 Inspired by autoslidR, I have integrated flextable functionality to convert "data.frame," "rtables," "TableTree," and "ElementaryTable" into flextable, which offers a more accurate representation. In this context, I have enhanced the TableBlock to facilitate the conversion of tables into flextable. Output screenshot <img width="1358" alt="Screenshot 2023-09-08 at 7 20 48 PM" src="https://github.com/insightsengineering/teal.reporter/assets/6700955/cde22fa1-3081-4ce9-84d5-d700a30b7749"> --------- Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com> Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com> Co-authored-by: kartikeya <kartikeya.kirar@unicle.life> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
Users report that slides generated from Teal apps at the moment are not really ready-to-use.
Examples attached input_20230317191236450.pptx
Table from ppt generated by teal app at default
![image](https://user-images.githubusercontent.com/78242757/233757076-19bbc8c7-c403-4a73-a20c-5fe8f0698c1a.png)
Table from ppt generated by teal app after dramatically reducing for font size
![image](https://user-images.githubusercontent.com/78242757/233757142-d8ac94a9-6b3e-4ea4-b5e9-af109aa5ac77.png)
Notable issues include
User wants to see
Suggestion - should look towards Roche internal package called
autoslideR
for inspiration and potential solutionsThe text was updated successfully, but these errors were encountered: