Apply Quosure and data in tmg #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gogonzo
reviewed
Aug 16, 2022
| @@ -327,16 +327,17 @@ ui_g_bivariate <- function(id, ...) { | |||
| ) | |||
| ) | |||
| ), | |||
| forms = teal::get_rcode_ui(ns("rcode")), | |||
| forms = teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code"), | |||
There was a problem hiding this comment.
Explanation comment
formerly teal::get_rcode_ui (and teal::get_rcode_srv) is dependent on chunks, thus it needs to be replaced.
Polkas
commented
Aug 16, 2022
Polkas
commented
Aug 16, 2022
gogonzo
reviewed
Aug 16, 2022
| @@ -371,26 +370,33 @@ srv_g_bivariate <- function(id, | |||
| selectors | |||
| }) | |||
|
|
|||
| merged_data <- teal.transform::data_merge_srv( | |||
| anl_merged_input <- teal.transform::merge_expression_srv( | |||
There was a problem hiding this comment.
Explanation comment
merge module does not return $data anymore so we can't call it merged_data
gogonzo
reviewed
Aug 16, 2022
gogonzo
reviewed
Aug 16, 2022
Comment on lines
+536
to
+537
| teal.code::eval_code(merged$anl_q_r(), substitute(expr = p <- cl, env = list(cl = cl)), name = "plot_call") %>% | ||
| teal.code::eval_code(print_call, name = "print_call") |
There was a problem hiding this comment.
Explanation comment
previously code has been added to the chunks using chunks_push and evaluated at the end using chunks_safe_eval.
Now we eval_code which is equivalent of chunks_push + chunks_eval
gogonzo
reviewed
Aug 17, 2022
…eering/teal.modules.general into 26_new_chunks@main
gogonzo
reviewed
Aug 18, 2022
gogonzo
reviewed
Aug 18, 2022
mhallal1
reviewed
Sep 2, 2022
mhallal1
reviewed
Sep 2, 2022
mhallal1
reviewed
Sep 2, 2022
mhallal1
reviewed
Sep 2, 2022
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
* Update check.yaml * test * linters_with_defaults * Update check.yaml
mhallal1
reviewed
Sep 6, 2022
Co-authored-by: Mahmoud Hallal <86970066+mhallal1@users.noreply.github.com>
mhallal1
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #388 #388