reporter cleaning #430
Merged
reporter cleaning #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage SummaryResults for commit: 160436541eae5e69753dbb09c17bf939723ba932 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
nikolas-burkoff
approved these changes
Jul 26, 2022
| @@ -432,7 +427,6 @@ srv_variable_browser <- function(id, datasets, reporter, datasets_selected, ggpl | |||
| card <- teal.reporter::TealReportCard$new() | |||
| card$set_name("Variable Browser Plot") | |||
| card$append_text("Variable Browser Plot", "header2") | |||
| card$append_text("Filter State", "header3") | |||
There was a problem hiding this comment.
Hmm so we need to record whether the use filtered data button was turned on or not as otherwise we could have the situation where say "Filtered State: x" but the Use filtered state button is set to FALSE and then the graph includes unfiltered data. Maybe we have if (input$<<use_filter>>) card$append_fs(...)
There was a problem hiding this comment.
good point, updated.
| @@ -352,27 +347,22 @@ srv_t_crosstable <- function(id, datasets, reporter, label, x, y, basic_table_ar | |||
| card <- teal.reporter::TealReportCard$new() | |||
| card$set_name("Cross Table") | |||
| card$append_text("Cross Table", "header2") | |||
| card$append_text("Filter State", "header3") | |||
There was a problem hiding this comment.
Do we have an issue to add encoding information into tmg modules as I could imagine say waning to know which join we've selected here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of insightsengineering/teal.reporter#88, insightsengineering/teal.reporter#120 and insightsengineering/teal.slice#56
Filter stateandShow R code