Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements to README/vignettes #993

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Minor improvements to README/vignettes #993

merged 3 commits into from
Jan 31, 2024

Conversation

edelarua
Copy link
Contributor

Pull Request

Fixes #992

@edelarua edelarua added the sme label Jan 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2024 •
edited
Loading

Unit Tests Summary

  1 files   33 suites   2s ⏱️
150 tests 150 ✅   0 💤 0 ❌
282 runs  170 ✅ 112 💤 0 ❌

Results for commit 1854e1e.

♻️ This comment has been updated with latest results.

shajoezhu
shajoezhu reviewed Jan 31, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@shajoezhu shajoezhu self-assigned this Jan 31, 2024
shajoezhu
shajoezhu approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @edelarua , some minor points see my comments. can merge once addressed. thanks again!

@edelarua edelarua merged commit 29069a5 into main Jan 31, 2024
25 checks passed
@edelarua edelarua deleted the 992_update_readme_vignettes@main branch January 31, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shajoezhu shajoezhu shajoezhu approved these changes

Assignees

@shajoezhu shajoezhu

Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor improvements to README/vignettes
2 participants
@edelarua @shajoezhu