-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
430 use expect_no_error
in tests instead of expect_error(, NA)
#936
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I added some prefixes and bumped {testthat}
edit: Nevermind my comment. The original branch was outdated, once you update from main
this problem is resolved
However, there's a weird issue with tests as there's a teal.transform::
missing that fails a test.
#> ── Failed tests ────────────────────────────────────────
#> Error (test-utils.R:270:3): cs_to_filter_spec creates filter_spec from choices_selected
#> Error in `value_choices(data, "a")`: could not find function "value_choices"
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
Thanks for verification! Would you mind accepting? |
Unit Tests Summary 1 files 33 suites 2s ⏱️ Results for commit b97400b. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
teal.data
is already defined above. Please make that change before merging
Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com> Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
Part of https://github.com/insightsengineering/coredev-tasks/issues/430