Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

430 use expect_no_error in tests instead of expect_error(, NA) #936

Merged
merged 5 commits into from
Jan 23, 2024

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jan 23, 2024

@m7pr m7pr added the core label Jan 23, 2024
@averissimo averissimo self-assigned this Jan 23, 2024
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I added some prefixes and bumped {testthat}

edit: Nevermind my comment. The original branch was outdated, once you update from main this problem is resolved

However, there's a weird issue with tests as there's a teal.transform:: missing that fails a test.

#> ── Failed tests ────────────────────────────────────────
#> Error (test-utils.R:270:3): cs_to_filter_spec creates filter_spec from choices_selected
#> Error in `value_choices(data, "a")`: could not find function "value_choices"

Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
@m7pr m7pr requested a review from averissimo January 23, 2024 15:10
@m7pr
Copy link
Contributor Author

m7pr commented Jan 23, 2024

Thanks for verification! Would you mind accepting?

Copy link
Contributor

github-actions bot commented Jan 23, 2024

Unit Tests Summary

  1 files   33 suites   2s ⏱️
149 tests 149 ✅   0 💤 0 ❌
280 runs  168 ✅ 112 💤 0 ❌

Results for commit b97400b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

teal.data is already defined above. Please make that change before merging

DESCRIPTION Outdated Show resolved Hide resolved
Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
@m7pr m7pr merged commit b66d149 into main Jan 23, 2024
23 of 24 checks passed
@m7pr m7pr deleted the 430_expect_no_error_tests@main branch January 23, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants