Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update forest plots following refactor of g_forest #911

Merged
merged 14 commits into from
Jan 3, 2024

Conversation

edelarua
Copy link
Contributor

Pull Request

Fixes #910

@edelarua edelarua added the sme label Dec 13, 2023
Copy link
Contributor

github-actions bot commented Dec 13, 2023

Unit Tests Summary

    1 files    33 suites   3s ⏱️
149 tests 149 ✔️     0 💤 0
280 runs  168 ✔️ 112 💤 0

Results for commit 694e229.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@ayogasekaram ayogasekaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @edelarua, Thank you for updating these!
I noticed something different in the display between main and this branch:
The labels and headers have an overlap in the application window
ggplot refactor:
image
main branch:
image

However, the plots look fine when they're downloaded as png. Is there a display setting we can update?

@edelarua
Copy link
Contributor Author

Hey @edelarua, Thank you for updating these! I noticed something different in the display between main and this branch: The labels and headers have an overlap in the application window

However, the plots look fine when they're downloaded as png. Is there a display setting we can update?

Hi @ayogasekaram,
For me, the default plot width when I click the expand button is 1670 (not sure how that's determined since plot_width is set to 1500). I see yours is at 1114 - if you slide that higher it should fix. When you open the module without popping out the plot is the width ok?

@ayogasekaram
Copy link
Contributor

Hey @edelarua, Thank you for updating these! I noticed something different in the display between main and this branch: The labels and headers have an overlap in the application window
However, the plots look fine when they're downloaded as png. Is there a display setting we can update?

Hi @ayogasekaram, For me, the default plot width when I click the expand button is 1670 (not sure how that's determined since plot_width is set to 1500). I see yours is at 1114 - if you slide that higher it should fix. When you open the module without popping out the plot is the width ok?

Yes, there's no overlap without the pop-up! I think it's good to go then :)

@shajoezhu
Copy link
Contributor

let's do this one after #907

Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @edelarua , thanks for the changes, please see my comments regarding rel_width_forest thanks!

@shajoezhu shajoezhu enabled auto-merge (squash) January 3, 2024 05:35
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks @edelarua

@shajoezhu shajoezhu merged commit 3339d51 into main Jan 3, 2024
24 checks passed
@shajoezhu shajoezhu deleted the 910_update_forest@1109_refactor_g_forest@main branch January 3, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update forest plot modules following refactor of g_forest
4 participants