-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update forest plots following refactor of g_forest
#911
Update forest plots following refactor of g_forest
#911
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @edelarua, Thank you for updating these!
I noticed something different in the display between main and this branch:
The labels and headers have an overlap in the application window
ggplot refactor:
main branch:
However, the plots look fine when they're downloaded as png. Is there a display setting we can update?
Hi @ayogasekaram, |
Yes, there's no overlap without the pop-up! I think it's good to go then :) |
let's do this one after #907 |
Signed-off-by: Joe Zhu <sha.joe.zhu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @edelarua , thanks for the changes, please see my comments regarding rel_width_forest
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thanks @edelarua
Pull Request
Fixes #910