Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chasing deprecations #852

Merged
merged 6 commits into from
Nov 16, 2023
Merged

chasing deprecations #852

merged 6 commits into from
Nov 16, 2023

Conversation

chlebowa
Copy link
Contributor

  • changes filer definition in example apps to use teal_slices
  • adds namespace prefixes to get_join_keys following moving the function to teal.data
  • adds teal.data to Imports

@chlebowa chlebowa added the core label Nov 16, 2023
@chlebowa chlebowa requested a review from edelarua November 16, 2023 02:55
@chlebowa chlebowa added the sme label Nov 16, 2023
@chlebowa chlebowa enabled auto-merge (squash) November 16, 2023 03:21
@github-actions GitHub Actions
Copy link
Contributor

Unit Tests Summary

    1 files    33 suites   3s ⏱️
149 tests 149 ✔️     0 💤 0 ❌
280 runs  168 ✔️ 112 💤 0 ❌

Results for commit c3c875c.

@chlebowa chlebowa mentioned this pull request Nov 16, 2023
Merged
edelarua
edelarua approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - thanks @chlebowa!!

@chlebowa chlebowa merged commit 3e00585 into main Nov 16, 2023
@chlebowa chlebowa deleted the oexamples_filter_definition@main branch November 16, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edelarua edelarua edelarua approved these changes

Assignees
No one assigned
Labels
core sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chlebowa @edelarua