Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

799 qenv prints plots to the device when running shiny app #800

Closed
wants to merge 6 commits into from
Closed

799 qenv prints plots to the device when running shiny app #800

wants to merge 6 commits into from

Conversation

kartikeyakirar
Copy link
Contributor

this PR fixes #799
and PR is related to issue insightsengineering/teal.code#84

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023 •
edited
Loading

Unit Tests Summary

    1 files    33 suites   3s ⏱️
149 tests 149 ✔️     0 💤 0 ❌
280 runs  168 ✔️ 112 💤 0 ❌

Results for commit 4df09d9.

♻️ This comment has been updated with latest results.

@kartikeyakirar kartikeyakirar requested a review from gogonzo August 1, 2023 07:57
gogonzo
gogonzo previously approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

none of the module print to the device anymore

@gogonzo gogonzo dismissed their stale review August 3, 2023 07:59

please wait

@gogonzo
Copy link
Contributor

gogonzo commented Aug 3, 2023

Hi @kartikeyakirar I'm happy you wait with this PR - we discovered that get_var is problematic when there is a validation error. I'm closing this PR and reverted teal.modules.general here -> insightsengineering/teal.modules.general#553

@gogonzo gogonzo closed this Aug 3, 2023
@gogonzo gogonzo deleted the 799_qenv_prints_plot@main branch August 3, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gogonzo gogonzo gogonzo left review comments

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

qenv prints plots to the device when running shiny app
2 participants
@kartikeyakirar @gogonzo