Fix numeric_stats bug in tm_t_summary and tm_t_summary_by
#771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edelarua
changed the title
numeric_stats bug in tm_t_summary_bynumeric_stats bug in tm_t_summary and tm_t_summary_by
Melkiades
approved these changes
May 26, 2023
Melkiades
reviewed
Jun 2, 2023
| checkmate::assert_class(pre_output, classes = "shiny.tag", null.ok = TRUE) | ||
| checkmate::assert_class(post_output, classes = "shiny.tag", null.ok = TRUE) | ||
| checkmate::assert_class(basic_table_args, "basic_table_args") | ||
|
|
||
| numeric_stats_choices <- c("n", "mean_sd", "mean_ci", "geom_mean", "median", "median_ci", "quantiles", "range") |
There was a problem hiding this comment.
I am agreeing a lot with #525 for this. It should be assigned dynamically from tern options. I am thinking how to do that. Also, notice that there seems to be a different number of methods here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #770